From: Toon Claes <toon@iotcl.com>
To: Junio C Hamano <gitster@pobox.com>, git@vger.kernel.org
Subject: Re: What's cooking in git.git (Nov 2026, #03)
Date: Mon, 09 Nov 2026 17:23:44 +0100 [thread overview]
Message-ID: <87pkwex9bj.fsf@dev.null.iotcl.com.invalid> (raw)
In-Reply-To: <xmqqmrrlfzcd.fsf@gitster.g>
Junio C Hamano <gitster@pobox.com> writes:
> * ps/grep-recurse-submodules-fix (2026-11-03) 3 commits
> - builtin/grep: read ".gitmodules" via passed-in repository
> - builtin/grep: read sparse directory trees via passed-in repository
> - builtin/grep: read submodule trees via their repository
>
> A regression where 'git grep --recurse-submodules' failed to read
> nested trees in a submodule has been fixed by passing the correct
> repository context pointer instead of relying on the global
> 'the_repository' variable. Additional latent bugs where grep_cache()
> and grep_objects() incorrectly referenced the global state have also
> been corrected.
>
> Needs review.
> source: <20261103-pks-grep-recurse-submodule-v2-0-b00e3b3dc865@pks.im>
My comment on v1 was addressed, and I've got no further comments about
v2. Changes are fairly small, and seem not at all controversial to me.
--
Laters,
Toon
next prev parent reply other threads:[~2026-11-09 16:23 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-06 21:02 What's cooking in git.git (Nov 2026, #03) Junio C Hamano
2026-11-09 16:23 ` Toon Claes [this message]
2026-11-09 18:48 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87pkwex9bj.fsf@dev.null.iotcl.com.invalid \
--to=toon@iotcl.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox