From: Nix <nix@esperi.org.uk>
To: Junio C Hamano <gitster@pobox.com>
Cc: git@vger.kernel.org
Subject: Re: [PATCH 1/2] Add strtoimax() compatibility function.
Date: Tue, 06 Sep 2011 10:14:16 +0100 [thread overview]
Message-ID: <87pqjejamv.fsf@spindle.srvr.nix> (raw)
In-Reply-To: <7v62l6b3bt.fsf@alter.siamese.dyndns.org> (Junio C. Hamano's message of "Mon, 05 Sep 2011 23:19:18 -0700")
On 6 Sep 2011, Junio C. Hamano spake thusly:
> Nix <nix@esperi.org.uk> writes:
>
>> Since systems that omit strtoumax() will likely omit strtomax() too,
>> and likewise for strtoull() and strtoll(), we also adjust the
>> compatibility #defines from NO_STRTOUMAX to NO_STRTOMAX and from
>> NO_STRTOULL to NO_STRTOLL, and have them cover both the signed and
>> unsigned functions.
>
> What would happen to people who know their systems lack strtoumax and have
> happily using NO_STRTOUMAX in their config.mak already? Do their build
> suddenly start breaking after this patch is applied and they all have to
> adjust to the new name?
Uh. Yeah. Oops.
> Even though "no strtoumax() likely means no strtoimax()" may be a good
> heuristics, I am not sure what we would gain by renaming these Makefile
> variables. Can't you get the same effect by making existing NO_STRTOUMAX
> imply not having strtoimax(), and if you did so, wouldn't it be much less
> likely that you would break existing people's build?
Yes, but I thought that might be too confusing (and having four
variables for this one case seemed ridiculous). I'm happy to rename it
back.
--
NULL && (void)
next prev parent reply other threads:[~2011-09-06 9:14 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-09-05 11:45 [PATCH 1/2] Add strtoimax() compatibility function Nix
2011-09-05 11:45 ` [PATCH 2/2] Support sizes >=2G in various config options accepting 'g' sizes Nix
2011-09-05 13:49 ` Sverre Rabbelier
2011-09-05 13:56 ` Nix
2011-09-06 7:44 ` Clemens Buchacher
2011-09-06 9:13 ` Nix
2011-09-06 10:22 ` Johannes Sixt
2011-09-06 10:25 ` Nix
2011-09-06 10:38 ` Johannes Sixt
2011-09-06 11:17 ` Nix
2011-09-06 6:19 ` [PATCH 1/2] Add strtoimax() compatibility function Junio C Hamano
2011-09-06 9:14 ` Nix [this message]
-- strict thread matches above, loose matches on Subject: below --
2011-11-02 15:46 [PATCH 0/2] Support sizes >=2G in various config options, v2 Nick Alcock
2011-11-02 15:46 ` [PATCH 1/2] Add strtoimax() compatibility function Nick Alcock
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87pqjejamv.fsf@spindle.srvr.nix \
--to=nix@esperi.org.uk \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).