Git development
 help / color / mirror / Atom feed
From: Pat Thoyts <patthoyts@users.sourceforge.net>
To: git@vger.kernel.org
Cc: paulus@samba.org
Cc: johannes.schindelin@gmx.de
Subject: [PATCH] gitk: avoid crash if closed while reading references
Date: 15 Apr 2009 17:14:03 +0100	[thread overview]
Message-ID: <87prfdnbck.fsf@users.sourceforge.net> (raw)


  As recorded in msysGit issue 125 if the user closes gitk while it
  reports itself as still reading references then Tk will crash in the
  geometry management code. This has been fixed for Tk 8.5.7 and above.
  This patch avoids the problem by flushing outstanding geometry events
  before calling the readrefs procedure.

  See also http://code.google.com/p/msysgit/issues/detail?id=125

Signed-off-by: Pat Thoyts <patthoyts@users.sourceforge.net>
---
 gitk |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)

diff --git a/gitk b/gitk
index 656c2c1..a346bd5 100755
--- a/gitk
+++ b/gitk
@@ -10952,6 +10952,7 @@ catch {
 # wait for the window to become visible
 tkwait visibility .
 wm title . "[file tail $argv0]: [file tail [pwd]]"
+update
 readrefs
 
 if {$cmdline_files ne {} || $revtreeargs ne {} || $revtreeargscmd ne {}} {
-- 
1.6.2.2.1669.g7eaf8

             reply	other threads:[~2009-04-15 16:15 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-04-15 16:14 Pat Thoyts [this message]
2009-04-15 16:46 ` [PATCH] gitk: avoid crash if closed while reading references Johannes Schindelin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87prfdnbck.fsf@users.sourceforge.net \
    --to=patthoyts@users.sourceforge.net \
    --cc=git@vger.kernel.org \
    --cc=paulus@samba.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox