From: Carl Worth <cworth@cworth.org>
To: Junio C Hamano <junkio@cox.net>
Cc: git@vger.kernel.org
Subject: Re: [PATCH] Don't propagate SKIPPED warning to future commits.
Date: Sat, 11 Feb 2006 06:47:39 -0800 [thread overview]
Message-ID: <87psluuf3o.wl%cworth@cworth.org> (raw)
In-Reply-To: <7vpslutz2t.fsf@assigned-by-dhcp.cox.net>
[-- Attachment #1: Type: text/plain, Size: 1006 bytes --]
On Fri, 10 Feb 2006 18:21:30 -0800, Junio C Hamano wrote:
>
> I might be missing something fundamental, but isn't propagating
> the warning a good thing?
Yes, that would be fine.
The problem with the current behavior is that the warnings accumulate
for every commit that affects the particular file. So, after import,
the head commit will have a commit message ending in:
SKIPPED: broken-file
SKIPPED: broken-file
SKIPPED: broken-file
...
With one line per affected commit. So an alternate patch that simply
kept the warning unique per file would be fine too.
The discussion may be entirely moot since I don't know when it is
reasonable for a file to be missing in this way. In my specific case I
think the missing ,v file happened due to a combination of factors,
including old data in ~/.cvsps, and that data being stale due to some
manual surgery on the ,v files, (copying or renaming or so).
It would probably be fine to leave the current behavior until someone
runs into this again.
-Carl
[-- Attachment #2: Type: application/pgp-signature, Size: 189 bytes --]
prev parent reply other threads:[~2006-02-11 14:48 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-02-11 1:41 [PATCH] Don't propagate SKIPPED warning to future commits Carl Worth
2006-02-11 2:21 ` Junio C Hamano
2006-02-11 14:47 ` Carl Worth [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87psluuf3o.wl%cworth@cworth.org \
--to=cworth@cworth.org \
--cc=git@vger.kernel.org \
--cc=junkio@cox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).