From mboxrd@z Thu Jan 1 00:00:00 1970 From: Carl Worth Subject: Re: [PATCH] Don't propagate SKIPPED warning to future commits. Date: Sat, 11 Feb 2006 06:47:39 -0800 Message-ID: <87psluuf3o.wl%cworth@cworth.org> References: <87r76avfhz.wl%cworth@cworth.org> <7vpslutz2t.fsf@assigned-by-dhcp.cox.net> Mime-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: multipart/signed; boundary="pgp-sign-Multipart_Sat_Feb_11_06:47:29_2006-1"; micalg=pgp-sha1; protocol="application/pgp-signature" Content-Transfer-Encoding: 7bit Cc: git@vger.kernel.org X-From: git-owner@vger.kernel.org Sat Feb 11 15:48:42 2006 Return-path: Envelope-to: gcvg-git@gmane.org Received: from vger.kernel.org ([209.132.176.167]) by ciao.gmane.org with esmtp (Exim 4.43) id 1F7w3B-0007zo-J7 for gcvg-git@gmane.org; Sat, 11 Feb 2006 15:48:37 +0100 Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932297AbWBKOsf (ORCPT ); Sat, 11 Feb 2006 09:48:35 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S932301AbWBKOsf (ORCPT ); Sat, 11 Feb 2006 09:48:35 -0500 Received: from theworths.org ([217.160.253.102]:49605 "EHLO theworths.org") by vger.kernel.org with ESMTP id S932297AbWBKOse (ORCPT ); Sat, 11 Feb 2006 09:48:34 -0500 Received: (qmail 15485 invoked from network); 11 Feb 2006 09:48:33 -0500 Received: from localhost (HELO raht.localdomain) (127.0.0.1) by localhost with SMTP; 11 Feb 2006 09:48:33 -0500 To: Junio C Hamano In-Reply-To: <7vpslutz2t.fsf@assigned-by-dhcp.cox.net> User-Agent: Wanderlust/2.14.0 (Africa) Emacs/21.4 Mule/5.0 (SAKAKI) Sender: git-owner@vger.kernel.org Precedence: bulk X-Mailing-List: git@vger.kernel.org Archived-At: --pgp-sign-Multipart_Sat_Feb_11_06:47:29_2006-1 Content-Type: text/plain; charset=US-ASCII On Fri, 10 Feb 2006 18:21:30 -0800, Junio C Hamano wrote: > > I might be missing something fundamental, but isn't propagating > the warning a good thing? Yes, that would be fine. The problem with the current behavior is that the warnings accumulate for every commit that affects the particular file. So, after import, the head commit will have a commit message ending in: SKIPPED: broken-file SKIPPED: broken-file SKIPPED: broken-file ... With one line per affected commit. So an alternate patch that simply kept the warning unique per file would be fine too. The discussion may be entirely moot since I don't know when it is reasonable for a file to be missing in this way. In my specific case I think the missing ,v file happened due to a combination of factors, including old data in ~/.cvsps, and that data being stale due to some manual surgery on the ,v files, (copying or renaming or so). It would probably be fine to leave the current behavior until someone runs into this again. -Carl --pgp-sign-Multipart_Sat_Feb_11_06:47:29_2006-1 Content-Type: application/pgp-signature Content-Transfer-Encoding: 7bit -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.2 (GNU/Linux) iD8DBQBD7fkL6JDdNq8qSWgRAkE5AJ0Y+S6siB5liil9QqEjILxjw3AG8wCeK7jz PvAEefVdRKu8475K6zQ730o= =kIR1 -----END PGP SIGNATURE----- --pgp-sign-Multipart_Sat_Feb_11_06:47:29_2006-1--