From: Toon Claes <toon@iotcl.com>
To: Karthik Nayak <karthik.188@gmail.com>,
Patrick Steinhardt <ps@pks.im>,
git@vger.kernel.org
Subject: Re: [PATCH 00/14] Stop using `the_repository` in some trivial cases
Date: Tue, 07 Jan 2025 22:12:24 +0100 [thread overview]
Message-ID: <87r05ejpl3.fsf@iotcl.com> (raw)
In-Reply-To: <CAOLa=ZTn2vfmS480G2wnaMehoK6+Z7EZ3Wx=ctaaPjBetOkbcA@mail.gmail.com>
Karthik Nayak <karthik.188@gmail.com> writes:
> I went through half of the patches a week ago, but got back to reading
> through the series today.
I've also been reading through the whole series today, and the changes
are trivial and look good to me.
> The approach here is to simply bubble up the usage of `the_repository`
> to upper layers and use `the_repository` there. The alternative approach
> would be to try and resolve the dependency on the upper layers and not
> use `the_repository`. This approach seems much safer. The patches look
> good to me.
I took me a while to get into the mindset of taking this approach, but
after chatting with Patrick I've changed my mind and agree with this
approach. The goal of this series is to eliminate the use of
`the_repository` in the mentioned subsystems. Simply bubbling up the use
of that variable to the callers of those subsystems is very trivial and
safe to do.
--
Toon
next prev parent reply other threads:[~2025-01-07 21:12 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-12-17 6:43 [PATCH 00/14] Stop using `the_repository` in some trivial cases Patrick Steinhardt
2024-12-17 6:43 ` [PATCH 01/14] progress: stop using `the_repository` Patrick Steinhardt
2024-12-31 6:42 ` Karthik Nayak
2025-01-06 20:57 ` Toon Claes
2025-01-07 7:19 ` Patrick Steinhardt
2024-12-17 6:43 ` [PATCH 02/14] pager: " Patrick Steinhardt
2024-12-17 12:17 ` shejialuo
2024-12-31 6:55 ` Karthik Nayak
2024-12-17 6:43 ` [PATCH 03/14] trace: " Patrick Steinhardt
2024-12-17 6:43 ` [PATCH 04/14] serve: " Patrick Steinhardt
2024-12-17 6:43 ` [PATCH 05/14] send-pack: " Patrick Steinhardt
2024-12-17 6:43 ` [PATCH 06/14] server-info: " Patrick Steinhardt
2024-12-17 12:31 ` shejialuo
2024-12-17 6:43 ` [PATCH 07/14] diagnose: " Patrick Steinhardt
2024-12-17 6:43 ` [PATCH 08/14] mailinfo: " Patrick Steinhardt
2024-12-17 6:43 ` [PATCH 09/14] credential: " Patrick Steinhardt
2024-12-17 6:43 ` [PATCH 10/14] resolve-undo: " Patrick Steinhardt
2024-12-17 6:43 ` [PATCH 11/14] tmp-objdir: " Patrick Steinhardt
2024-12-17 6:43 ` [PATCH 12/14] add-interactive: " Patrick Steinhardt
2024-12-17 6:44 ` [PATCH 13/14] graph: " Patrick Steinhardt
2024-12-17 6:44 ` [PATCH 14/14] match-trees: " Patrick Steinhardt
2024-12-17 12:45 ` [PATCH 00/14] Stop using `the_repository` in some trivial cases shejialuo
2024-12-27 14:26 ` Patrick Steinhardt
2025-01-07 11:41 ` Karthik Nayak
2025-01-07 21:12 ` Toon Claes [this message]
2025-01-07 21:15 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87r05ejpl3.fsf@iotcl.com \
--to=toon@iotcl.com \
--cc=git@vger.kernel.org \
--cc=karthik.188@gmail.com \
--cc=ps@pks.im \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).