From: Pat Thoyts <patthoyts@users.sourceforge.net>
To: msysgit@googlegroups.com
Cc: git@vger.kernel.org
Subject: [PATCH] Skip t1300.70 and 71 on msysGit.
Date: Mon, 15 Feb 2010 23:14:28 +0000 [thread overview]
Message-ID: <87r5omghop.fsf@users.sourceforge.net> (raw)
These two tests fail on msysGit because /dev/null is an alias for nul on
Windows and when reading the value back from git config the alias does
not match the real filename. Also the HOME environment variable has a
unix-style path but git returns a native equivalent path for '~'. As
these are platform-dependent equivalent results it seems simplest to
skip the test entirely.
Signed-off-by: Pat Thoyts <patthoyts@users.sourceforge.net>
---
t/t1300-repo-config.sh | 6 +++---
t/test-lib.sh | 1 +
2 files changed, 4 insertions(+), 3 deletions(-)
diff --git a/t/t1300-repo-config.sh b/t/t1300-repo-config.sh
index f11f98c..90541a3 100755
--- a/t/t1300-repo-config.sh
+++ b/t/t1300-repo-config.sh
@@ -701,7 +701,7 @@ cat >expect <<\EOF
trailingtilde = foo~
EOF
-test_expect_success 'set --path' '
+test_expect_success NONMINGW 'set --path' '
git config --path path.home "~/" &&
git config --path path.normal "/dev/null" &&
git config --path path.trailingtilde "foo~" &&
@@ -713,14 +713,14 @@ $HOME/
foo~
EOF
-test_expect_success 'get --path' '
+test_expect_success NONMINGW 'get --path' '
git config --get --path path.home > result &&
git config --get --path path.normal >> result &&
git config --get --path path.trailingtilde >> result &&
test_cmp expect result
'
-rm .git/config
+test_have_prereq NONMINGW && rm .git/config
git config quote.leading " test"
git config quote.ending "test "
diff --git a/t/test-lib.sh b/t/test-lib.sh
index afd3053..f6a1590 100644
--- a/t/test-lib.sh
+++ b/t/test-lib.sh
@@ -776,6 +776,7 @@ case $(uname -s) in
test_set_prereq POSIXPERM
test_set_prereq BSLASHPSPEC
test_set_prereq EXECKEEPSPID
+ test_set_prereq NONMINGW
;;
esac
--
1.7.0.rc2.1438.gebbe6.dirty
next reply other threads:[~2010-02-16 0:14 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-02-15 23:14 Pat Thoyts [this message]
2010-02-16 9:27 ` [msysGit] [PATCH] Skip t1300.70 and 71 on msysGit Johannes Schindelin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87r5omghop.fsf@users.sourceforge.net \
--to=patthoyts@users.sourceforge.net \
--cc=git@vger.kernel.org \
--cc=msysgit@googlegroups.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).