From: Collin Funk <collin.funk1@gmail.com>
To: Brad Smith <brad@comstyle.com>
Cc: git@vger.kernel.org
Subject: Re: [PATCH v2] compat: fixes for header handling with OpenBSD / NetBSD
Date: Mon, 02 Jun 2025 21:39:36 -0700 [thread overview]
Message-ID: <87sekhqvzr.fsf@gmail.com> (raw)
In-Reply-To: <aD52RXZVAsXpimBG@humpty.home.comstyle.com>
Brad Smith <brad@comstyle.com> writes:
> Handle OpenBSD and NetBSD as FreeBSD / DragonFly are. OpenBSD would
> need _XOPEN_SOURCE to be set to 700. Its simpler to just not set
> _XOPEN_SOURCE.
>
> CC strbuf.o
> strbuf.c:645:6: warning: call to undeclared function 'getdelim'; ISO C99 and later do not support implicit function declarations [-Wimplicit-function-declaration]
> r = getdelim(&sb->buf, &sb->alloc, term, fp);
> ^
> 1 warning generated.
>
> Signed-off-by: Brad Smith <brad@comstyle.com>
> ---
> compat/posix.h | 10 +++++-----
> 1 file changed, 5 insertions(+), 5 deletions(-)
Thanks!
Reviewed-by: Collin Funk <collin.funk1@gmail.com>
Collin
prev parent reply other threads:[~2025-06-03 4:39 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-06-03 4:12 [PATCH v2] compat: fixes for header handling with OpenBSD / NetBSD Brad Smith
2025-06-03 4:39 ` Collin Funk [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87sekhqvzr.fsf@gmail.com \
--to=collin.funk1@gmail.com \
--cc=brad@comstyle.com \
--cc=git@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).