From: "Ævar Arnfjörð Bjarmason" <avarab@gmail.com>
To: Jeff King <peff@peff.net>
Cc: git@vger.kernel.org, Derrick Stolee <dstolee@microsoft.com>
Subject: Re: [PATCH 7/9] commit-graph: drop count_distinct_commits() function
Date: Sat, 05 Dec 2020 03:26:56 +0100 [thread overview]
Message-ID: <87sg8lxa1b.fsf@evledraar.gmail.com> (raw)
In-Reply-To: <X8qGTaIdnNa5mAfC@coredump.intra.peff.net>
On Fri, Dec 04 2020, Jeff King wrote:
> When writing a commit graph, we collect a list of object ids in an
> array, which we'll eventually copy into an array of "struct commit"
> pointers. Before we do that, though, we count the number of distinct
> commit entries. There's a subtle bug in this step, though.
> [...]
> - display_progress(ctx->progress, 0); /* TODO: Measure QSORT() progress */
> - QSORT(ctx->oids.list, ctx->oids.nr, oid_compare);
> [...]
> + QSORT(ctx->oids.list, ctx->oids.nr, oid_compare);
One thing your commit messag doesn't note is the removal of this
TODO. Theoretically we still have the issue I noted in 890226ccb57
(commit-graph write: add itermediate progress, 2019-01-19), in practice
I think it's fine to just forever remove this TODO.
I tried now on a really big repo and couldn't even get the progress bar
you removed to appear, or the one you moved the QSORT() to.
Maybe I need to go even bigger, but more likely I overdid things a bit
when I added all these progress bars to commit-graph.c at the time.
next prev parent reply other threads:[~2020-12-05 2:28 UTC|newest]
Thread overview: 40+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-04 18:48 [PATCH 0/9] misc commit-graph and oid-array cleanups Jeff King
2020-12-04 18:48 ` [PATCH 1/9] oid-array.h: drop sha1 mention from header guard Jeff King
2020-12-04 18:49 ` [PATCH 2/9] t0064: drop sha1 mention from filename Jeff King
2020-12-04 18:50 ` [PATCH 3/9] t0064: make duplicate tests more robust Jeff King
2020-12-04 18:51 ` [PATCH 4/9] cache.h: move hash/oid functions to hash.h Jeff King
2020-12-04 18:52 ` [PATCH 5/9] oid-array: make sort function public Jeff King
2020-12-04 18:53 ` [PATCH 6/9] oid-array: provide a for-loop iterator Jeff King
2020-12-04 19:05 ` Taylor Blau
2020-12-04 19:11 ` Taylor Blau
2020-12-04 19:52 ` Jeff King
2020-12-04 19:51 ` Jeff King
2020-12-04 19:18 ` Eric Sunshine
2020-12-04 20:44 ` Jeff King
2020-12-04 20:57 ` Eric Sunshine
2020-12-04 21:54 ` Junio C Hamano
2020-12-07 19:05 ` Jeff King
2020-12-04 18:56 ` [PATCH 7/9] commit-graph: drop count_distinct_commits() function Jeff King
2020-12-04 20:06 ` Derrick Stolee
2020-12-04 20:42 ` Jeff King
2020-12-04 20:47 ` Derrick Stolee
2020-12-04 20:50 ` Jeff King
2020-12-04 21:01 ` Derrick Stolee
2020-12-05 2:26 ` Ævar Arnfjörð Bjarmason [this message]
2020-12-07 19:01 ` Jeff King
2020-12-04 18:57 ` [PATCH 8/9] commit-graph: replace packed_oid_list with oid_array Jeff King
2020-12-04 19:14 ` Taylor Blau
2020-12-04 18:58 ` [PATCH 9/9] commit-graph: use size_t for array allocation and indexing Jeff King
2020-12-04 19:15 ` [PATCH 0/9] misc commit-graph and oid-array cleanups Taylor Blau
2020-12-04 20:08 ` Derrick Stolee
2020-12-07 19:10 ` [PATCH v2 " Jeff King
2020-12-07 19:10 ` [PATCH v2 1/9] oid-array.h: drop sha1 mention from header guard Jeff King
2020-12-07 19:10 ` [PATCH v2 2/9] t0064: drop sha1 mention from filename Jeff King
2020-12-07 19:10 ` [PATCH v2 3/9] t0064: make duplicate tests more robust Jeff King
2020-12-07 19:10 ` [PATCH v2 4/9] cache.h: move hash/oid functions to hash.h Jeff King
2020-12-07 19:10 ` [PATCH v2 5/9] oid-array: make sort function public Jeff King
2020-12-07 19:11 ` [PATCH v2 6/9] oid-array: provide a for-loop iterator Jeff King
2020-12-07 19:11 ` [PATCH v2 7/9] commit-graph: drop count_distinct_commits() function Jeff King
2020-12-07 19:11 ` [PATCH v2 8/9] commit-graph: replace packed_oid_list with oid_array Jeff King
2020-12-07 19:11 ` [PATCH v2 9/9] commit-graph: use size_t for array allocation and indexing Jeff King
2020-12-07 19:26 ` [PATCH v2 0/9] misc commit-graph and oid-array cleanups Derrick Stolee
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87sg8lxa1b.fsf@evledraar.gmail.com \
--to=avarab@gmail.com \
--cc=dstolee@microsoft.com \
--cc=git@vger.kernel.org \
--cc=peff@peff.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).