From: David Kastrup <dak@gnu.org>
To: Junio C Hamano <gitster@pobox.com>
Cc: git@vger.kernel.org
Subject: Re: RFC GSoc Idea: blame: do not overly favor earlier parents
Date: Thu, 06 Mar 2014 21:21:39 +0100 [thread overview]
Message-ID: <87siqvcc30.fsf@fencepost.gnu.org> (raw)
In-Reply-To: <xmqq8usnxfi1.fsf@gitster.dls.corp.google.com> (Junio C. Hamano's message of "Thu, 06 Mar 2014 12:02:14 -0800")
Junio C Hamano <gitster@pobox.com> writes:
> When looking at a merge, "git blame" inspects the blob object names
> of all parents and if one of them exactly match the merge result,
> pass the entire blame down to that parent. This is very much in
> line with the history simplification done with "git log" when
> traversing a history with merges.
[...]
> Now, imagine if you amend M to create N, to add a single line at the
> end of path. M:path != N:path but there is very small difference
> between the two. That means B:path != N:path but the difference
> between this merged result and the second parent is very small.
That sounds very much like
commit d5df1593f27bfceab807242a538cb3fa01256efd
Merge: 7144168 0b4e246
Author: Junio C Hamano <gitster@pobox.com>
Date: Fri Feb 28 13:51:19 2014 -0800
Merge branch 'bl/blame-full-history' into pu
By disabling the tree-same optimization (which is consistent with
the default behaviour of "git log"-family of commands), make "git
blame" sometimes produce different result from the original code.
Because the "git blame" output can give result for each line from
only one lineage of the history, however, this can be only useful
when you are lucky---unlike "--full-history" of "git log"-family,
where we can show commits from both lineages of histories with an
equal weight. See $gmane/240392 for more detailed discussion.
* bl/blame-full-history:
blame: new option --prefer-first to better handle merged cherry-picks
--
David Kastrup
next prev parent reply other threads:[~2014-03-06 20:21 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-03-06 20:02 RFC GSoc Idea: blame: do not overly favor earlier parents Junio C Hamano
2014-03-06 20:21 ` David Kastrup [this message]
2014-03-06 20:24 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87siqvcc30.fsf@fencepost.gnu.org \
--to=dak@gnu.org \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).