From mboxrd@z Thu Jan 1 00:00:00 1970 From: Thomas Rast Subject: Re: [PATCH] subtree: fix argument validation in add/pull/push Date: Wed, 27 Nov 2013 20:19:29 +0100 Message-ID: <87siuhfy9q.fsf@thomasrast.ch> References: <1385577249-29269-1-git-send-email-Anthony.Baire@irisa.fr> Mime-Version: 1.0 Content-Type: text/plain Cc: git@vger.kernel.org To: Anthony Baire X-From: git-owner@vger.kernel.org Wed Nov 27 20:19:49 2013 Return-path: Envelope-to: gcvg-git-2@plane.gmane.org Received: from vger.kernel.org ([209.132.180.67]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1VlkeI-0000jc-Kb for gcvg-git-2@plane.gmane.org; Wed, 27 Nov 2013 20:19:46 +0100 Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756837Ab3K0TTm (ORCPT ); Wed, 27 Nov 2013 14:19:42 -0500 Received: from psi.thgersdorf.net ([176.9.98.78]:60692 "EHLO mail.psioc.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751648Ab3K0TTl (ORCPT ); Wed, 27 Nov 2013 14:19:41 -0500 Received: from localhost (localhost [127.0.0.1]) by localhost.psioc.net (Postfix) with ESMTP id 5B48E4D65A0; Wed, 27 Nov 2013 20:19:40 +0100 (CET) X-Virus-Scanned: amavisd-new at psioc.net Received: from mail.psioc.net ([127.0.0.1]) by localhost (mail.psioc.net [127.0.0.1]) (amavisd-new, port 10024) with LMTP id PGl9fh8SqDMk; Wed, 27 Nov 2013 20:19:30 +0100 (CET) Received: from linux-1gf2.thomasrast.ch (46-126-8-85.dynamic.hispeed.ch [46.126.8.85]) (using TLSv1.2 with cipher AES128-GCM-SHA256 (128/128 bits)) (Client did not present a certificate) by mail.psioc.net (Postfix) with ESMTPSA id C10D44D659F; Wed, 27 Nov 2013 20:19:29 +0100 (CET) In-Reply-To: <1385577249-29269-1-git-send-email-Anthony.Baire@irisa.fr> (Anthony Baire's message of "Wed, 27 Nov 2013 19:34:09 +0100") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3 (gnu/linux) Sender: git-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: git@vger.kernel.org Archived-At: Anthony Baire writes: > When working with a remote repository add/pull/push do not accept a > as parameter but just a . They should accept any > well-formatted ref name. [...] > - update the doc to use instead of [...] > OPTS_SPEC="\ > git subtree add --prefix= > -git subtree add --prefix= > +git subtree add --prefix= > git subtree merge --prefix= > -git subtree pull --prefix= > -git subtree push --prefix= > +git subtree pull --prefix= > +git subtree push --prefix= > git subtree split --prefix= [...] > @@ -68,7 +68,7 @@ COMMANDS > -------- > add:: > Create the subtree by importing its contents > - from the given or and remote . > + from the given or and remote . AFAICS you are changing refspec->commit in the manpage, but commit->ref in the usage message for 'subtree add'? How does this line up? -- Thomas Rast tr@thomasrast.ch