git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Thomas Rast <trast@student.ethz.ch>
To: Junio C Hamano <gitster@pobox.com>
Cc: "Dale R. Worley" <worley@alum.mit.edu>, <git@vger.kernel.org>
Subject: Re: "git rebase" loses the additional changes in "evil" merges
Date: Mon, 4 Mar 2013 22:24:07 +0100	[thread overview]
Message-ID: <87sj4aoo3s.fsf@pctrast.inf.ethz.ch> (raw)
In-Reply-To: <7vtxoqx3s1.fsf@alter.siamese.dyndns.org> (Junio C. Hamano's message of "Mon, 04 Mar 2013 13:18:22 -0800")

Junio C Hamano <gitster@pobox.com> writes:

> worley@alum.mit.edu (Dale R. Worley) writes:
>
>> (git version 1.7.7.6)
>>
>> I've been learning how to use Git.  While exploring "git rebase", I've
>> discovered that if the branch being rebased contains an "evil" merge,
>> that is, a merge which contains changes that are in addition to the
>> changes in any of the parent commits, the rebase operation will
>> silenty lose those additional changes.
>
> I think this is to be expected for "git rebase", as it does not even
> look at merges.  It is a way to find non-merge commits that haven't
> been applied yet, and apply them to the upstream to create a new
> linear history.

I can see the problem with --preserve-merges though.  It will actually
just *redo* the merge; the name is wrong in the sense that it undertakes
nothing to preserve whatever evilness was in it.

I suppose in theory it could first redo the merge on the original
parents, and diff against the existing merge; that would be the evilness
component.  Then it could attempt to apply the same evilness on the new
merge.

-- 
Thomas Rast
trast@{inf,student}.ethz.ch

  reply	other threads:[~2013-03-04 21:25 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-03-04 20:58 "git rebase" loses the additional changes in "evil" merges Dale R. Worley
2013-03-04 21:18 ` Junio C Hamano
2013-03-04 21:24   ` Thomas Rast [this message]
2013-03-04 21:41     ` Junio C Hamano
2013-03-06 18:55       ` What I want rebase to do Dale R. Worley
2013-03-07  8:48         ` Thomas Rast
2013-03-07 10:08           ` Johannes Sixt
2013-03-07 17:38           ` Junio C Hamano
2013-03-07 22:06           ` Dale R. Worley
2013-03-05 21:18   ` "git rebase" loses the additional changes in "evil" merges Dale Worley
2013-03-05 21:35     ` Junio C Hamano
2013-03-05 23:16       ` Philip Oakley
2013-03-05 23:31         ` Junio C Hamano

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87sj4aoo3s.fsf@pctrast.inf.ethz.ch \
    --to=trast@student.ethz.ch \
    --cc=git@vger.kernel.org \
    --cc=gitster@pobox.com \
    --cc=worley@alum.mit.edu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).