From: Toon Claes <toon@iotcl.com>
To: Patrick Steinhardt <ps@pks.im>
Cc: git@vger.kernel.org, Root <rootminus0x1@gmail.com>
Subject: Re: [PATCH 1/3] builtin/grep: read submodule trees via their repository
Date: Mon, 09 Nov 2026 17:22:01 +0100 [thread overview]
Message-ID: <87tslqx9ee.fsf@dev.null.iotcl.com.invalid> (raw)
In-Reply-To: <aunAR67MHppLt--N@pks.im>
Patrick Steinhardt <ps@pks.im> writes:
>> Small nit, shall we use test_when_finished here?
>
> Normally I would, but in this case it would have felt weird to have "rm
> -rf sub super && test_when_finished "rm -rf sub super". We have to
> delete the old repos because they exist already, so arguably the correct
> location to add the `test_when_finished` would have been that preceding
> test. But I'd propose that this can be done at a later time?
Sure.
--
Laters,
Toon
next prev parent reply other threads:[~2026-11-09 16:22 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-30 10:21 [PATCH 0/3] builtin/grep: fix reading objects from wrong repository Patrick Steinhardt
2026-10-30 10:21 ` [PATCH 1/3] builtin/grep: read submodule trees via their repository Patrick Steinhardt
2026-10-30 16:25 ` Toon Claes
2026-11-03 11:06 ` Patrick Steinhardt
2026-11-09 16:22 ` Toon Claes [this message]
2026-10-30 10:21 ` [PATCH 2/3] builtin/grep: read sparse directory trees via passed-in repository Patrick Steinhardt
2026-10-30 10:21 ` [PATCH 3/3] builtin/grep: read ".gitmodules" " Patrick Steinhardt
2026-11-03 12:43 ` [PATCH v2 0/3] builtin/grep: fix reading objects from wrong repository Patrick Steinhardt
2026-11-03 12:43 ` [PATCH v2 1/3] builtin/grep: read submodule trees via their repository Patrick Steinhardt
2026-11-03 12:43 ` [PATCH v2 2/3] builtin/grep: read sparse directory trees via passed-in repository Patrick Steinhardt
2026-11-03 12:43 ` [PATCH v2 3/3] builtin/grep: read ".gitmodules" " Patrick Steinhardt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87tslqx9ee.fsf@dev.null.iotcl.com.invalid \
--to=toon@iotcl.com \
--cc=git@vger.kernel.org \
--cc=ps@pks.im \
--cc=rootminus0x1@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox