git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: "Ævar Arnfjörð Bjarmason" <avarab@gmail.com>
To: Jeff King <peff@peff.net>
Cc: Johannes Schindelin <johannes.schindelin@gmx.de>,
	git@vger.kernel.org, Junio C Hamano <gitster@pobox.com>
Subject: Re: [PATCH] t5404: relax overzealous test
Date: Fri, 06 Apr 2018 22:35:43 +0200	[thread overview]
Message-ID: <87tvsoysww.fsf@evledraar.gmail.com> (raw)
In-Reply-To: <20180406195331.GC11450@sigill.intra.peff.net>


On Fri, Apr 06 2018, Jeff King wrote:

> On Fri, Apr 06, 2018 at 09:31:22PM +0200, Johannes Schindelin wrote:
>> This patch chooses instead to look for the prefix "error:" at the
>> beginning of the line, so that there can be no ambiguity that any catch
>> was indeed a message generated by Git's `error_builtin()` function.
>
> Yep, this seems obviously correct.
>
> Right now we do not localize the "error" string, but I wonder if this
> ought to use test_i18ngrep. With or without that change, the patch looks
> good to me.

I think it's much better not to do that.

There's value in the i18n versions checking for only those things that
are translated, and no more, because we should really be on the lookout
for any i18n changes that potentially change plumbing output, or other
things programs expect to parse.

  parent reply	other threads:[~2018-04-06 20:35 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-04-06 19:31 [PATCH] t5404: relax overzealous test Johannes Schindelin
2018-04-06 19:53 ` Jeff King
2018-04-06 20:13   ` Johannes Schindelin
2018-04-06 20:16     ` Jeff King
2018-04-06 20:35   ` Ævar Arnfjörð Bjarmason [this message]
2018-04-09  2:21   ` Junio C Hamano
2018-04-09 13:52     ` Johannes Schindelin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87tvsoysww.fsf@evledraar.gmail.com \
    --to=avarab@gmail.com \
    --cc=git@vger.kernel.org \
    --cc=gitster@pobox.com \
    --cc=johannes.schindelin@gmx.de \
    --cc=peff@peff.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).