From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on dcvr.yhbt.net X-Spam-Level: X-Spam-ASN: AS31976 209.132.180.0/23 X-Spam-Status: No, score=-2.7 required=3.0 tests=AWL,BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, FROM_EXCESS_BASE64,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, RCVD_IN_DNSWL_HI,T_RP_MATCHES_RCVD shortcircuit=no autolearn=ham autolearn_force=no version=3.4.0 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by dcvr.yhbt.net (Postfix) with ESMTP id AEDD81F404 for ; Fri, 6 Apr 2018 20:35:49 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751741AbeDFUfr (ORCPT ); Fri, 6 Apr 2018 16:35:47 -0400 Received: from mail-wm0-f42.google.com ([74.125.82.42]:39467 "EHLO mail-wm0-f42.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751696AbeDFUfq (ORCPT ); Fri, 6 Apr 2018 16:35:46 -0400 Received: by mail-wm0-f42.google.com with SMTP id f125so5387903wme.4 for ; Fri, 06 Apr 2018 13:35:46 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:references:user-agent:in-reply-to:date :message-id:mime-version; bh=nH7IMMO6Y24mhg3Kc5Gj8zlbo2Uc+LWARPBFlfAHXoE=; b=DP56fXNbS8VdU5TXC3CxZJCEWKeOmJtpTuIBDkHLJceBWBigK0Kp611GWhe2f6BOHQ cNZ9VvHp0AuYmqXeu3FvZ03jWJEuqYgly1ftuAVSzI8/BX1kIsPVzdsq8HWgws61W/P0 hk5kxpFkAy74ss8JYPxoMPYquxs8qzen3OEfO0a8FtZJwZWv+fScut7AgL2bgm8PP9NK tppvqSvRgPbPMTHHfvN2/sLrRi1oD9pND3CBYD5D+6/wFDA819fdV1UQvOGnbkgSe2PF dh+7321vr8mVwhSIacdCfTNdlfC/pDB2t/j8z0z/UrX3ofYpTcEp6OPoV7Qb6GMvqmFF kSvQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:user-agent :in-reply-to:date:message-id:mime-version; bh=nH7IMMO6Y24mhg3Kc5Gj8zlbo2Uc+LWARPBFlfAHXoE=; b=gdPNfCqMuzyMyvQZtVf+UlgnsUnSfiP3QWA0ePY5Ie8b6bbEaICD6fqjI7odWt51wL VVcv/zzac744B5230oBuYKpTYlZUDU/+4nTzQUB4xqEX6C+ZnIW3DzGIQmYyRqKn5mY8 dyA1tb0CXRoQdSV8jwSgdIhklhDDORcp7Xr8iXpxVpO76XX/pbY9aLodP9aE3Kh/HDrs i39tRZbuk9JDGDohdY1RAy8VI5fY9t/sSL0pnnwJGkvnPEneKY/7+nvN6C21lwQGTYUg CPbH8R0BHlLEzLAas+2mLMYUPr6oXvyg/WuzSh2S8OaLvE1Eoa9eHsBUlL+Qd2Zf1juk vufg== X-Gm-Message-State: ALQs6tC/oIAmwVICNMmtThk/BagOPhvv7UNTnrGCxpKe/mel4Vt/SrR2 WY0/K9K/px220kb1QSjOg5I= X-Google-Smtp-Source: AIpwx4+gbMLZi7hHnubez1x/+xuEcaIZI3dxxW63jHg9XgXdihxEkGbr0NL+9fuRao7ZgPasj8oycw== X-Received: by 10.80.166.99 with SMTP id d90mr8512637edc.53.1523046945550; Fri, 06 Apr 2018 13:35:45 -0700 (PDT) Received: from evledraar (dhcp-089-098-184-206.chello.nl. [89.98.184.206]) by smtp.gmail.com with ESMTPSA id n30sm6964886edd.45.2018.04.06.13.35.44 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Fri, 06 Apr 2018 13:35:44 -0700 (PDT) From: =?utf-8?B?w4Z2YXIgQXJuZmrDtnLDsA==?= Bjarmason To: Jeff King Cc: Johannes Schindelin , git@vger.kernel.org, Junio C Hamano Subject: Re: [PATCH] t5404: relax overzealous test References: <958ee6f006aba0c67c8e064d31206e3e68a1cc49.1523043053.git.johannes.schindelin@gmx.de> <20180406195331.GC11450@sigill.intra.peff.net> User-agent: Debian GNU/Linux 9.4 (stretch); Emacs 25.1.1; mu4e 1.1.0 In-reply-to: <20180406195331.GC11450@sigill.intra.peff.net> Date: Fri, 06 Apr 2018 22:35:43 +0200 Message-ID: <87tvsoysww.fsf@evledraar.gmail.com> MIME-Version: 1.0 Content-Type: text/plain Sender: git-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: git@vger.kernel.org On Fri, Apr 06 2018, Jeff King wrote: > On Fri, Apr 06, 2018 at 09:31:22PM +0200, Johannes Schindelin wrote: >> This patch chooses instead to look for the prefix "error:" at the >> beginning of the line, so that there can be no ambiguity that any catch >> was indeed a message generated by Git's `error_builtin()` function. > > Yep, this seems obviously correct. > > Right now we do not localize the "error" string, but I wonder if this > ought to use test_i18ngrep. With or without that change, the patch looks > good to me. I think it's much better not to do that. There's value in the i18n versions checking for only those things that are translated, and no more, because we should really be on the lookout for any i18n changes that potentially change plumbing output, or other things programs expect to parse.