From: Thomas Rast <trast@inf.ethz.ch>
To: Junio C Hamano <gitster@pobox.com>
Cc: "Thomas \"Enki\" Badie" <thomas.badie@gmail.com>,
<git@vger.kernel.org>, Thomas Rast <trast@student.ethz.ch>
Subject: Re: [PATCH] git-add--interactive.perl: Remove two unused variables
Date: Mon, 25 Jun 2012 11:12:14 +0200 [thread overview]
Message-ID: <87txxzu55d.fsf@thomas.inf.ethz.ch> (raw)
In-Reply-To: <7vfw9khrrt.fsf@alter.siamese.dyndns.org> (Junio C. Hamano's message of "Sun, 24 Jun 2012 22:41:58 -0700")
Junio C Hamano <gitster@pobox.com> writes:
> "Thomas \"Enki\" Badie" <thomas.badie@gmail.com> writes:
>
>> The patch 8f0bef6 refactors this script and leaves the `$fh' variable
>> unused in `diff_applies' and `patch_update_file'.
[...]
> (2) the author of the problematic commit should have been Cc'ed
> (especially when he is still an active participant on the list)
> to give him a chance to Ack it (I'm adding Thomas for this).
Indeed, my bad. It's easy to verify from 'git show 8f0bef6' that this
was an oversight in my patch.
Acked-by: Thomas Rast <trast@student.ethz.ch>
--
Thomas Rast
trast@{inf,student}.ethz.ch
next prev parent reply other threads:[~2012-06-25 9:12 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-06-24 21:37 [PATCH] git-add--interactive.perl: Remove two unused variables Thomas "Enki" Badie
2012-06-25 5:41 ` Junio C Hamano
2012-06-25 9:12 ` Thomas Rast [this message]
2012-06-25 10:16 ` Thomas Badie
2012-06-25 10:12 ` Thomas Badie
2012-06-25 18:06 ` Junio C Hamano
2012-06-25 22:41 ` Thomas Badie
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87txxzu55d.fsf@thomas.inf.ethz.ch \
--to=trast@inf.ethz.ch \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=thomas.badie@gmail.com \
--cc=trast@student.ethz.ch \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).