git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: "Rémi Vanicat" <vanicat@debian.org>
To: git@vger.kernel.org
Subject: Re: [Wishlist] could git tell which password it is asking when asking a password.
Date: Fri, 01 Jul 2011 21:25:59 +0200	[thread overview]
Message-ID: <87tyb5n6pk.dlv@debian.org> (raw)
In-Reply-To: 7vwrg1opov.fsf@alter.siamese.dyndns.org

Junio C Hamano <gitster@pobox.com> writes:

> Shawn Pearce <spearce@spearce.org> writes:
>
>> On Fri, Jul 1, 2011 at 10:16, Junio C Hamano <gitster@pobox.com> wrote:
>>> Junio C Hamano <gitster@pobox.com> writes:
>>> diff --git a/http.c b/http.c
>>> index b2ae8de..44948a7 100644
>>> --- a/http.c
>>> +++ b/http.c
>>> @@ -209,8 +209,11 @@ static void init_curl_http_auth(CURL *result)
>>>  {
>>>        if (user_name) {
>>>                struct strbuf up = STRBUF_INIT;
>>> -               if (!user_pass)
>>> -                       user_pass = xstrdup(git_getpass("Password: "));
>>> +               if (!user_pass) {
>>> +                       strbuf_addf(&up, "Password for %s: ", user_name);
>>
>> The user_name by itself may not be sufficient. I may also need the URL
>> to correctly answer the question. I don't always use the same password
>> on every website. :-)
>>
>> As a human sure, I know what URL I asked Git to poke for me.
>
> I was wondering about that when I gave that quick patch.  And "as a human"
> may not necessarily apply when you are letting submodule fetch to recurse.

I also believe that having the host name would be useful, both for human
(another example would be git remote update when there are several
remote) and script.  

-- 
Rémi Vanicat

  reply	other threads:[~2011-07-01 19:26 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-07-01 13:59 [Wishlist] could git tell which password it is asking when asking a password Rémi Vanicat
2011-07-01 17:00 ` Junio C Hamano
2011-07-01 17:16   ` Junio C Hamano
2011-07-01 17:18     ` Shawn Pearce
2011-07-01 17:50       ` Junio C Hamano
2011-07-01 19:25         ` Rémi Vanicat [this message]
2011-07-01 20:01           ` Ted Zlatanov
2011-07-01 20:30           ` Junio C Hamano
2011-07-01 20:48             ` Jeff King
2011-07-01 20:46   ` Jeff King
2011-07-01 17:04 ` Ted Zlatanov
2011-07-14 14:05   ` encrypted netrc for Git (was: [Wishlist] could git tell which password it is asking when asking a password.) Ted Zlatanov
2011-07-14 15:00     ` Jeff King
2011-07-15 17:08       ` encrypted netrc for Git Ted Zlatanov
2011-07-15 21:05         ` Jeff King

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87tyb5n6pk.dlv@debian.org \
    --to=vanicat@debian.org \
    --cc=git@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).