From: Toon Claes <toon@iotcl.com>
To: Junio C Hamano <gitster@pobox.com>, git@vger.kernel.org
Subject: Re: What's cooking in git.git (Nov 2026, #05)
Date: Fri, 13 Nov 2026 11:08:12 +0100 [thread overview]
Message-ID: <87v7613uyb.fsf@dev.null.iotcl.com.invalid> (raw)
In-Reply-To: <xmqqpkw9fwc1.fsf@gitster.g>
Junio C Hamano <gitster@pobox.com> writes:
> * ps/odb-loose-stale-cache (2026-11-04) 2 commits
> - odb/source-loose: fix existence checks for newly written objects
> - odb/source-loose: extract logic to retrieve subdirectory bitmap
>
> The loose object cache has been updated to track newly written loose
> objects to prevent stale cache entries from causing existence checks
> to fail, which previously caused issues when lazy-fetching missing
> objects during a partial clone.
>
> Needs review.
> cf. <xmqqfqxg32uy.fsf@gitster.g>
> cf. <CAL71e4ONN4OQUZ2S==0TRWqZgA8ogT0smRL3Rk46voTm+0Tihw@mail.gmail.com>
> cf. <55e14977-dfc2-4acc-bc71-a91915fa251f@gmail.com>
> cf. <20261105194314.GB2898829@coredump.intra.peff.net>
> cf. <au23Hvzp09yrym9s@pks.im>
> cf. <xmqq5wyalzi2.fsf@gitster.g>
> cf. <avHOTt_PEJUKq9Dy@pks.im>
> source: <20261104-pks-odb-loose-stale-cache-v1-0-a00d5cdb5e7d@pks.im>
As various other people confirmed, the changes also look good to me. It
fixes the bug at hand, that's the most important.
About the NEEDSWORK comments, I'd suggest to integrate that as-is (above
OBJECT_INFO_FOR_PREFETCH) for now.
--
Laters,
Toon
prev parent reply other threads:[~2026-11-13 10:08 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-12 23:45 What's cooking in git.git (Nov 2026, #05) Junio C Hamano
2026-11-13 10:08 ` Toon Claes [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87v7613uyb.fsf@dev.null.iotcl.com.invalid \
--to=toon@iotcl.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox