From: Thomas Rast <trast@inf.ethz.ch>
To: "Schmidt, Marco" <Marco.Schmidt@cassidian.com>
Cc: <git@vger.kernel.org>, <gitster@pobox.com>, <avarab@gmail.com>
Subject: Re: Patchset NTLM-Authentication
Date: Tue, 21 Feb 2012 10:22:17 +0100 [thread overview]
Message-ID: <87vcn0h77a.fsf@thomas.inf.ethz.ch> (raw)
In-Reply-To: <4CDEC141B5583D408E79F2931DB7708301802B70@GSX300A.mxchg.m.corp> (Marco Schmidt's message of "Tue, 21 Feb 2012 09:07:59 +0100")
"Schmidt, Marco" <Marco.Schmidt@cassidian.com> writes:
> I'm not conform with your patch submitting policy. I had no chance to
> track the git repository from my current location.
You should read Documentation/SubmittingPatches. If your location does
not let you use any git:// or git+http:// ("smart http") transports, you
can use the wereHamster's bundler service https://bundler.caurea.org/ to
get a bundle that you can download over http. (If you cannot download
*anything* over http, what is your internet access good for?)
Looking at the attachments:
[0002-Einf-hren-der-HTTP-Proxy-Authentifizierung.patch]
[0003-First-working-step.patch]
[0004-remove-debug-information.patch]
* You seem to have forgotten the first patch. As it stands, the 0002
one does not apply to my tree.
* The commit messages are useless. The second one at least says
"introduce HTTP proxy authentication" which tells me something about
*what it does*, but in German. It should also tell me why and how and
possible other considerations. See SubmittingPatches.
* The commits should "spring into perfect existence". That is, in the
above you should squash 3 and 4 into 2 so that 2 starts out working
(presumably -- I'm only looking at the subjects) . You can use rebase
-i to clean everything up.
--
Thomas Rast
trast@{inf,student}.ethz.ch
next prev parent reply other threads:[~2012-02-21 9:22 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-02-21 8:07 Patchset NTLM-Authentication Schmidt, Marco
2012-02-21 9:22 ` Thomas Rast [this message]
[not found] ` <4CDEC141B5583D408E79F2931DB7708301802BE7@GSX300A.mxchg.m.corp>
2012-02-21 13:28 ` Thomas Rast
2012-02-21 18:02 ` Junio C Hamano
2012-02-21 19:02 ` Daniel Stenberg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87vcn0h77a.fsf@thomas.inf.ethz.ch \
--to=trast@inf.ethz.ch \
--cc=Marco.Schmidt@cassidian.com \
--cc=avarab@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).