From: "David Kågedal" <davidk@lysator.liu.se>
To: git@vger.kernel.org, Junichi Uekawa <dancer@netfort.gr.jp>
Cc: Xavier Maillard <zedek@gnu.org>
Subject: Re: [PATCH] git-blame.el: show the when, who and what in the minibuffer.
Date: Mon, 11 Feb 2008 16:20:21 +0100 [thread overview]
Message-ID: <87ve4vr03u.fsf@lysator.liu.se> (raw)
In-Reply-To: <87ve4vo7g4.dancerj%dancer@netfort.gr.jp> (Junichi Uekawa's message of "Tue\, 12 Feb 2008 00\:00\:07 +0900")
Junichi Uekawa <dancer@netfort.gr.jp> writes:
> Change the default operation to show 'when (day the commit was made),
> who (who made the commit), what (what the commit log was)' in the
> minibuffer instead of SHA1 and title of the commit log.
>
> Since the user may prefer other displaying options, it is made as a
> user-configurable option.
Good idea.
> ---
> contrib/emacs/git-blame.el | 10 +++++++++-
> 1 files changed, 9 insertions(+), 1 deletions(-)
>
> diff --git a/contrib/emacs/git-blame.el b/contrib/emacs/git-blame.el
> index bb671d5..99e2b6f 100644
> --- a/contrib/emacs/git-blame.el
> +++ b/contrib/emacs/git-blame.el
> @@ -105,6 +105,13 @@ selected element from l."
> (setq ,l (remove e ,l))
> e))
>
> +(defvar git-blame-log-oneline-format
> + "format:[%cr] %cn: %s"
> + "*Formatting option used for describing current line in the minibuffer.
> +
> +This option is used to pass to git log --pretty= command-line option,
> +and describe which commit the current line was made.")
> +
> (defvar git-blame-dark-colors
> (git-blame-color-scale "0c" "04" "24" "1c" "2c" "34" "14" "3c")
> "*List of colors (format #RGB) to use in a dark environment.
> @@ -371,7 +378,8 @@ See also function `git-blame-mode'."
> (defun git-describe-commit (hash)
> (with-temp-buffer
> (call-process "git" nil t nil
> - "log" "-1" "--pretty=oneline"
> + "log" "-1"
> + (concat "--pretty=" git-blame-log-oneline-format)
> hash)
> (buffer-substring (point-min) (1- (point-max)))))
--
David Kågedal
next prev parent reply other threads:[~2008-02-11 15:20 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-02-11 15:00 [PATCH] git-blame.el: show the when, who and what in the minibuffer Junichi Uekawa
2008-02-11 15:20 ` David Kågedal [this message]
2008-02-14 2:00 ` Xavier Maillard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87ve4vr03u.fsf@lysator.liu.se \
--to=davidk@lysator.liu.se \
--cc=dancer@netfort.gr.jp \
--cc=git@vger.kernel.org \
--cc=zedek@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).