* [PATCH] git-blame.el: show the when, who and what in the minibuffer.
@ 2008-02-11 15:00 Junichi Uekawa
2008-02-11 15:20 ` David Kågedal
2008-02-14 2:00 ` Xavier Maillard
0 siblings, 2 replies; 3+ messages in thread
From: Junichi Uekawa @ 2008-02-11 15:00 UTC (permalink / raw)
To: git; +Cc: Xavier Maillard, David Kågedal
Change the default operation to show 'when (day the commit was made),
who (who made the commit), what (what the commit log was)' in the
minibuffer instead of SHA1 and title of the commit log.
Since the user may prefer other displaying options, it is made as a
user-configurable option.
---
contrib/emacs/git-blame.el | 10 +++++++++-
1 files changed, 9 insertions(+), 1 deletions(-)
diff --git a/contrib/emacs/git-blame.el b/contrib/emacs/git-blame.el
index bb671d5..99e2b6f 100644
--- a/contrib/emacs/git-blame.el
+++ b/contrib/emacs/git-blame.el
@@ -105,6 +105,13 @@ selected element from l."
(setq ,l (remove e ,l))
e))
+(defvar git-blame-log-oneline-format
+ "format:[%cr] %cn: %s"
+ "*Formatting option used for describing current line in the minibuffer.
+
+This option is used to pass to git log --pretty= command-line option,
+and describe which commit the current line was made.")
+
(defvar git-blame-dark-colors
(git-blame-color-scale "0c" "04" "24" "1c" "2c" "34" "14" "3c")
"*List of colors (format #RGB) to use in a dark environment.
@@ -371,7 +378,8 @@ See also function `git-blame-mode'."
(defun git-describe-commit (hash)
(with-temp-buffer
(call-process "git" nil t nil
- "log" "-1" "--pretty=oneline"
+ "log" "-1"
+ (concat "--pretty=" git-blame-log-oneline-format)
hash)
(buffer-substring (point-min) (1- (point-max)))))
--
1.5.3.8
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] git-blame.el: show the when, who and what in the minibuffer.
2008-02-11 15:00 [PATCH] git-blame.el: show the when, who and what in the minibuffer Junichi Uekawa
@ 2008-02-11 15:20 ` David Kågedal
2008-02-14 2:00 ` Xavier Maillard
1 sibling, 0 replies; 3+ messages in thread
From: David Kågedal @ 2008-02-11 15:20 UTC (permalink / raw)
To: git, Junichi Uekawa; +Cc: Xavier Maillard
Junichi Uekawa <dancer@netfort.gr.jp> writes:
> Change the default operation to show 'when (day the commit was made),
> who (who made the commit), what (what the commit log was)' in the
> minibuffer instead of SHA1 and title of the commit log.
>
> Since the user may prefer other displaying options, it is made as a
> user-configurable option.
Good idea.
> ---
> contrib/emacs/git-blame.el | 10 +++++++++-
> 1 files changed, 9 insertions(+), 1 deletions(-)
>
> diff --git a/contrib/emacs/git-blame.el b/contrib/emacs/git-blame.el
> index bb671d5..99e2b6f 100644
> --- a/contrib/emacs/git-blame.el
> +++ b/contrib/emacs/git-blame.el
> @@ -105,6 +105,13 @@ selected element from l."
> (setq ,l (remove e ,l))
> e))
>
> +(defvar git-blame-log-oneline-format
> + "format:[%cr] %cn: %s"
> + "*Formatting option used for describing current line in the minibuffer.
> +
> +This option is used to pass to git log --pretty= command-line option,
> +and describe which commit the current line was made.")
> +
> (defvar git-blame-dark-colors
> (git-blame-color-scale "0c" "04" "24" "1c" "2c" "34" "14" "3c")
> "*List of colors (format #RGB) to use in a dark environment.
> @@ -371,7 +378,8 @@ See also function `git-blame-mode'."
> (defun git-describe-commit (hash)
> (with-temp-buffer
> (call-process "git" nil t nil
> - "log" "-1" "--pretty=oneline"
> + "log" "-1"
> + (concat "--pretty=" git-blame-log-oneline-format)
> hash)
> (buffer-substring (point-min) (1- (point-max)))))
--
David Kågedal
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] git-blame.el: show the when, who and what in the minibuffer.
2008-02-11 15:00 [PATCH] git-blame.el: show the when, who and what in the minibuffer Junichi Uekawa
2008-02-11 15:20 ` David Kågedal
@ 2008-02-14 2:00 ` Xavier Maillard
1 sibling, 0 replies; 3+ messages in thread
From: Xavier Maillard @ 2008-02-14 2:00 UTC (permalink / raw)
To: Junichi Uekawa; +Cc: git, zedek, davidk
Hi,
Change the default operation to show 'when (day the commit was made),
who (who made the commit), what (what the commit log was)' in the
minibuffer instead of SHA1 and title of the commit log.
Love this even more with the user configurable option.
Xavier
--
http://www.gnu.org
http://www.april.org
http://www.lolica.org
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2008-02-14 2:03 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2008-02-11 15:00 [PATCH] git-blame.el: show the when, who and what in the minibuffer Junichi Uekawa
2008-02-11 15:20 ` David Kågedal
2008-02-14 2:00 ` Xavier Maillard
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).