From: Carl Worth <cworth@cworth.org>
To: "H. Peter Anvin" <hpa@zytor.com>
Cc: git <git@vger.kernel.org>, Junio C Hamano <junkio@cox.net>
Subject: Re: Make "git am" properly unescape lines matching ">>*From "
Date: Tue, 08 Jun 2010 14:30:25 -0700 [thread overview]
Message-ID: <87wru9i55a.fsf@yoom.home.cworth.org> (raw)
In-Reply-To: <4C0EAE08.60904@zytor.com>
[-- Attachment #1: Type: text/plain, Size: 1144 bytes --]
On Tue, 08 Jun 2010 13:54:32 -0700, "H. Peter Anvin" <hpa@zytor.com> wrote:
> On 06/08/2010 01:47 PM, Carl Worth wrote:
> > I've also noticed that format-patch is generating bogus mbox files
> > without any escaping. (The only way it gets away with this is that
> > mailsplit only treats "From " lines as separators if they end with
> > something that looks quite a bit like the output of asctime.)
>
> At the same time, it would be a fairly major lose to not be able to
> generate individual messages easily. I have personally considered the
> fact that git format-patch produces something-vaguely-like mboxes rather
> than individual plain RFC 2822 messages to be a bug; fixable by "tail"
> but annoying.
I totally agree. I said as much later on in the message. We should fix
format-patch to not emit the "From " line when generating files for
individual messages, (and we should fix send-email to accept such a bare
file).
That much is easy to agree on since it involves using mbox less, so the
whole "which mbox format to use?" question goes away, (for these uses at
least).
-Carl
--
carl.d.worth@intel.com
[-- Attachment #2: Type: application/pgp-signature, Size: 189 bytes --]
next prev parent reply other threads:[~2010-06-08 21:30 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <87hbldjo0s.fsf@yoom.home.cworth.org>
2010-06-08 20:02 ` [PATCH 1/2] mailsplit: Remove any '>' characters used to escape From_ lines in mbox Carl Worth
2010-06-08 20:02 ` [PATCH 2/2] Add test from From_-line escaping Carl Worth
2010-06-08 20:47 ` Make "git am" properly unescape lines matching ">>*From " Carl Worth
2010-06-08 20:54 ` H. Peter Anvin
2010-06-08 21:30 ` Carl Worth [this message]
2010-06-08 20:50 ` H. Peter Anvin
2010-06-08 21:52 ` Carl Worth
2010-06-08 22:10 ` H. Peter Anvin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87wru9i55a.fsf@yoom.home.cworth.org \
--to=cworth@cworth.org \
--cc=git@vger.kernel.org \
--cc=hpa@zytor.com \
--cc=junkio@cox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).