From: Giuseppe Scrivano <gscrivano@gnu.org>
To: Sverre Rabbelier <srabbelier@gmail.com>
Cc: Johannes Schindelin <Johannes.Schindelin@gmx.de>, git@vger.kernel.org
Subject: Re: [PATCH] Remove various dead assignments and dead increments found by the clang static analyzer
Date: Sat, 26 Sep 2009 20:46:45 +0200 [thread overview]
Message-ID: <87ws3lczmy.fsf@master.homenet> (raw)
In-Reply-To: <fabb9a1e0909261134qd90dba1n9637fe4adc253fc1@mail.gmail.com> (Sverre Rabbelier's message of "Sat, 26 Sep 2009 20:34:22 +0200")
Hello,
Sverre Rabbelier <srabbelier@gmail.com> writes:
> Then it would probably have been better to say so by at least marking
> your patch as RFC and including such a remark in the cover letter, no?
> Also, now that this has been pointed out, you shouldn't expect it to
> be included until someone either takes your patch and cleans it up (as
> in, checks all statements manually), or until you do so yourself.
I really had to include a RFC remark. After what Johannes reported, I
think there is need only to restore assignments to argc while other ones
can be dropped without problems. I'll post a cleaned patch later.
Cheers,
Giuseppe
next prev parent reply other threads:[~2009-09-26 18:48 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-09-26 14:46 [PATCH] Remove various dead assignments and dead increments found by the clang static analyzer Giuseppe Scrivano
2009-09-26 15:58 ` Johannes Schindelin
2009-09-26 18:21 ` Giuseppe Scrivano
2009-09-26 18:34 ` Sverre Rabbelier
2009-09-26 18:46 ` Giuseppe Scrivano [this message]
2009-09-26 19:15 ` Giuseppe Scrivano
2009-09-26 19:28 ` René Scharfe
2009-09-26 20:39 ` Johannes Schindelin
2009-09-26 20:46 ` Jeff King
2009-09-26 21:03 ` Reece Dunn
2009-09-26 21:12 ` Jeff King
2009-09-26 21:20 ` Reece Dunn
2009-09-26 21:36 ` Jeff King
2009-09-26 21:46 ` Reece Dunn
2009-09-26 21:42 ` Giuseppe Scrivano
2009-09-27 0:41 ` Nicolas Pitre
2009-09-27 8:21 ` Giuseppe Scrivano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87ws3lczmy.fsf@master.homenet \
--to=gscrivano@gnu.org \
--cc=Johannes.Schindelin@gmx.de \
--cc=git@vger.kernel.org \
--cc=srabbelier@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).