From: Collin Funk <collin.funk1@gmail.com>
To: Brad Smith <brad@comstyle.com>
Cc: git@vger.kernel.org
Subject: Re: [PATCH] compat: fixes for header handling with OpenBSD / NetBSD
Date: Mon, 02 Jun 2025 21:05:43 -0700 [thread overview]
Message-ID: <87y0u9qxk8.fsf@gmail.com> (raw)
In-Reply-To: <47c58a78-d38b-4170-87fc-c9332618d0da@comstyle.com>
Brad Smith <brad@comstyle.com> writes:
>> Why remove this definition? I think it might be useful on some older
>> systems and seems harmless otherwise.
>
> _XOPEN_SOURCE restricts the build environment. _NETBSD_SOURCE is added
> to counteract
> _XOPEN_SOURCE. Not setting it in the first place provides everything
> by default.
>
> I was removing it as it should no longer be necessary.
>
> But as said, it is harmless. I can leave it in if desired.
In Autoconf's AC_USE_SYSTEM_EXTENSIONS it is defined with the comment:
/* Enable general extensions on NetBSD.
Enable NetBSD compatibility extensions on Minix. */
I would prefer just leaving it for any old system that may need it. Or
in case git uses features from a recent standard that might still be
hidden as a NetBSD extension.
For example, POSIX.1-2024 has been released, but most functions added
there are still under _GNU_SOURCE in current glibc.
Collin
next prev parent reply other threads:[~2025-06-03 4:05 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-06-02 7:29 [PATCH] compat: fixes for header handling with OpenBSD / NetBSD Brad Smith
2025-06-02 18:06 ` Collin Funk
2025-06-03 0:36 ` Junio C Hamano
2025-06-03 3:56 ` Brad Smith
2025-06-03 4:05 ` Collin Funk [this message]
2025-06-03 14:37 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87y0u9qxk8.fsf@gmail.com \
--to=collin.funk1@gmail.com \
--cc=brad@comstyle.com \
--cc=git@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).