From: Teemu Likonen <tlikonen@iki.fi>
To: Allan Caffee <allan.caffee@gmail.com>
Cc: git@vger.kernel.org, "Junio C Hamano" <gitster@pobox.com>
Subject: Re: [PATCH] graph API: fix extra space during pre_commit_line state
Date: Wed, 22 Apr 2009 06:25:33 +0300 [thread overview]
Message-ID: <87y6tt2wuq.fsf@iki.fi> (raw)
In-Reply-To: <20090421183412.GA8499@linux.vnet> (Allan Caffee's message of "Tue\, 21 Apr 2009 14\:34\:12 -0400")
On 2009-04-21 14:34 (-0400), Allan Caffee wrote:
> An extra space is being inserted between the "commit" column and all of
> the successive edges. Remove this space. This regression was
> introduced by 427fc5b.
>
> Signed-off-by: Allan Caffee <allan.caffee@gmail.com>
Looks like it's working now, thanks. Let's Cc to Junio so that he
doesn't miss the fix.
> This issue exposes a gap in the existing test coverage, which doesn't
> exercise the pre_commit_line code. Maybe another patch is in order to
> extend t4202-log to cover pre-commit lines and octopus merges.
I think that's a good idea. I like "log --graph" very much and when
someone alters that part of the code I run my own visual "test suites"
to notice if my pet feature has been broken. :-) Automatic tests would
be helpful.
next prev parent reply other threads:[~2009-04-22 3:27 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-04-21 0:40 [RFC/PATCH] graph API: Use horizontal lines for more compact graphs Allan Caffee
2009-04-21 0:56 ` Johannes Schindelin
2009-04-21 2:23 ` Allan Caffee
2009-04-21 8:13 ` Johannes Schindelin
2009-04-21 12:47 ` [RFC/PATCH v2] " Allan Caffee
2009-04-21 13:17 ` Johannes Schindelin
2009-04-21 13:36 ` Bug in colored "log --graph" implementation Teemu Likonen
2009-04-21 18:34 ` [PATCH] graph API: fix extra space during pre_commit_line state Allan Caffee
2009-04-22 3:25 ` Teemu Likonen [this message]
2009-04-22 19:38 ` Allan Caffee
2009-04-22 19:52 ` [PATCH 2/3] " Allan Caffee
2009-04-22 21:27 ` [PATCH 1/3] t4202-log: extend test coverage of graphing Allan Caffee
2009-04-22 21:27 ` [PATCH 2/3] graph API: fix extra space during pre_commit_line state Allan Caffee
2009-04-22 21:27 ` [PATCH 3/3] graph API: fix a bug in the rendering of octopus merges Allan Caffee
2009-04-22 21:28 ` [RFC/PATCH v2] graph API: Use horizontal lines for more compact graphs Allan Caffee
2009-04-27 15:43 ` [PATCH v2 (resend)] " Allan Caffee
2009-04-27 16:35 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87y6tt2wuq.fsf@iki.fi \
--to=tlikonen@iki.fi \
--cc=allan.caffee@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).