From: "David Kågedal" <davidk@lysator.liu.se>
To: "Catalin Marinas" <catalin.marinas@gmail.com>,
"Karl Hasselström" <kha@treskal.com>
Cc: git@vger.kernel.org
Subject: Re: [StGit PATCH 5/5] Emacs mode: use "stg new --file"
Date: Mon, 11 Feb 2008 10:25:44 +0100 [thread overview]
Message-ID: <87zlu7sv3b.fsf@lysator.liu.se> (raw)
In-Reply-To: <20080210204434.17683.61684.stgit@yoghurt> ("Karl Hasselström"'s message of "Sun\, 10 Feb 2008 21\:46\:04 +0100")
Karl Hasselström <kha@treskal.com> writes:
> Creating a new patch is a great deal easier now that "stg new" has a
> --file flag.
>
> Signed-off-by: Karl Hasselström <kha@treskal.com>
>
> ---
>
> David, will you sanity-check this? I don't really speak elisp, so I
> might have done something insane without knowing it. But it does seem
> to work. :-)
Looks sane to me.
> contrib/stgit.el | 10 ++--------
> 1 files changed, 2 insertions(+), 8 deletions(-)
>
>
> diff --git a/contrib/stgit.el b/contrib/stgit.el
> index bef41c7..30c1cd1 100644
> --- a/contrib/stgit.el
> +++ b/contrib/stgit.el
> @@ -316,16 +316,10 @@ Commands:
>
> (defun stgit-confirm-new ()
> (interactive)
> - (let ((file (make-temp-file "stgit-edit-"))
> - (patch (stgit-create-patch-name
> - (buffer-substring (point-min)
> - (save-excursion (goto-char (point-min))
> - (end-of-line)
> - (point))))))
> + (let ((file (make-temp-file "stgit-edit-")))
> (write-region (point-min) (point-max) file)
> (stgit-capture-output nil
> - (stgit-run "new" "-m" "placeholder" patch)
> - (stgit-run "edit" "-f" file patch))
> + (stgit-run "new" "-f" file))
> (with-current-buffer log-edit-parent-buffer
> (stgit-refresh))))
>
>
--
David Kågedal
next prev parent reply other threads:[~2008-02-11 9:26 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-02-10 20:36 StGit: kha/safe and kha/experimental updated Karl Hasselström
2008-02-10 20:40 ` [StGit PATCH 0/5] Convert "stg new" to the new infrastructure Karl Hasselström
2008-02-10 20:43 ` [StGit PATCH 1/5] Disable patchlog test for "stg new" Karl Hasselström
2008-02-10 20:43 ` [StGit PATCH 2/5] Convert "stg new" to the new infrastructure Karl Hasselström
2008-02-10 20:44 ` [StGit PATCH 3/5] Refactor --author/--committer options Karl Hasselström
2008-02-12 22:05 ` Subject: [PATCH] fix stg edit command Peter Oberndorfer
2008-02-12 22:47 ` Karl Hasselström
2008-02-12 23:08 ` [StGit PATCH] Refactor --author/--committer options Karl Hasselström
2008-02-10 20:44 ` [StGit PATCH 4/5] Let "stg new" support more message options Karl Hasselström
2008-02-10 20:46 ` [StGit PATCH 5/5] Emacs mode: use "stg new --file" Karl Hasselström
2008-02-11 9:25 ` David Kågedal [this message]
2008-02-11 9:47 ` Karl Hasselström
2008-02-10 20:47 ` [StGit PATCH 0/2] Convert "stg delete" to the new infrastructure Karl Hasselström
2008-02-10 20:48 ` [StGit PATCH 1/2] " Karl Hasselström
2008-02-10 20:54 ` [StGit PATCH 2/2] Emacs mode: delete patches Karl Hasselström
2008-02-11 9:42 ` David Kågedal
2008-02-11 9:51 ` Karl Hasselström
2008-02-11 10:12 ` David Kågedal
2008-02-11 22:25 ` [StGit PATCH 1/2] Emacs mode: change "stg repair" binding Karl Hasselström
2008-02-11 22:26 ` [StGit PATCH v2 2/2] Emacs mode: delete patches Karl Hasselström
2008-02-12 17:54 ` StGit: kha/safe and kha/experimental updated Catalin Marinas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87zlu7sv3b.fsf@lysator.liu.se \
--to=davidk@lysator.liu.se \
--cc=catalin.marinas@gmail.com \
--cc=git@vger.kernel.org \
--cc=kha@treskal.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).