From: Alexandre Julliard <julliard@winehq.org>
To: Junio C Hamano <junkio@cox.net>
Cc: "Ismail Dönmez" <ismail@pardus.org.tr>,
git@vger.kernel.org, "Jakub Narebski" <jnareb@gmail.com>
Subject: Re: [PATCH] gitweb: use decode_utf8 directly
Date: Fri, 01 Jun 2007 15:45:31 +0200 [thread overview]
Message-ID: <87zm3ju6tg.fsf@wine.dyndns.org> (raw)
In-Reply-To: <7vsladzp29.fsf@assigned-by-dhcp.cox.net> (Junio C. Hamano's message of "Thu\, 03 May 2007 12\:26\:22 -0700")
Junio C Hamano <junkio@cox.net> writes:
> I would say that the patch is an improvement from the current
> code so it should hit 'master'; I was a bit busy lately and then
> am sick, and also we are post -rc1 freeze now and I was being
> cautious, just in case some nacks from more informed parties
> arrive late.
Sorry for the late nack, but it turns out that this patch breaks diff
output on the Wine server for files that are not utf-8.
The cause is apparently that decode_utf8() returns undef for invalid
sequences instead of substituting a replacement char like
decode("utf8") does.
That may be considered an Encode bug since we are running a fairly old
version (1.99, coming with Debian 3.1), but I'd rather not upgrade
perl on the server. Could the patch be reverted, or done differently?
--
Alexandre Julliard
julliard@winehq.org
next prev parent reply other threads:[~2007-06-01 13:45 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-04-24 14:05 [PATCH] gitweb: use decode_utf8 directly Ismail Dönmez
2007-04-27 8:55 ` Ismail Dönmez
2007-04-27 9:07 ` Junio C Hamano
2007-04-27 9:22 ` Ismail Dönmez
2007-04-27 19:29 ` Junio C Hamano
2007-05-01 21:12 ` Ismail Dönmez
2007-05-01 21:39 ` Junio C Hamano
2007-05-01 21:44 ` Ismail Dönmez
2007-05-01 21:48 ` Ismail Dönmez
2007-05-03 19:22 ` Ismail Dönmez
2007-05-03 19:26 ` Junio C Hamano
2007-06-01 13:45 ` Alexandre Julliard [this message]
2007-06-01 13:50 ` Ismail Dönmez
2007-06-01 16:51 ` Alexandre Julliard
2007-06-01 19:44 ` Junio C Hamano
2007-06-01 19:47 ` Ismail Dönmez
2007-06-01 20:00 ` Junio C Hamano
2007-06-01 20:08 ` Ismail Dönmez
2007-06-03 22:06 ` Junio C Hamano
2007-06-03 22:13 ` Ismail Dönmez
2007-06-02 8:22 ` Jakub Narebski
-- strict thread matches above, loose matches on Subject: below --
2007-06-01 16:13 Martin Koegler
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87zm3ju6tg.fsf@wine.dyndns.org \
--to=julliard@winehq.org \
--cc=git@vger.kernel.org \
--cc=ismail@pardus.org.tr \
--cc=jnareb@gmail.com \
--cc=junkio@cox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).