From: "James Pickens" <jepicken@gmail.com>
To: devel@morey-chaisemartin.com
Cc: git@vger.kernel.org
Subject: Re: [RFC PATCH 0/2] Add support for multi threaded checkout
Date: Thu, 18 Dec 2008 18:04:29 -0700 [thread overview]
Message-ID: <885649360812181704l3a905ebfrb90f391e86004efc@mail.gmail.com> (raw)
In-Reply-To: <494ABDC9.9060001@morey-chaisemartin.com>
On Thu, Dec 18, 2008, Nicolas Morey-Chaisemartin
<devel@morey-chaisemartin.com> wrote:
> I guess you could do something like :
>
> #define checkout_lock() core_threaded_checkout ?pthread_mutex_lock(&checkout_mutex) : (void) 0
> #define checkout_unlock() core_threaded_checkout ?pthread_mutex_unlock(&checkout_mutex) : (void) 0
I tried that, and to make it easier to see the impact, I changed the
'wrote = write_in_full(...)' calls in entry.c to 'wrote = size'. That
makes git just create a bunch of empty files instead of writing the real
contents to disk. Here's the result, with core.threadedcheckout set to
false, best of 2 runs:
original patch: 3.19
original + above: 3.18
So the cost of locking/unlocking the mutex looks vanishingly small in the
single thread case.
This also puts an upper bound on the time required for a single thread to
unpack the data.
James
prev parent reply other threads:[~2008-12-19 1:05 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-12-18 20:51 [RFC PATCH 0/2] Add support for multi threaded checkout Pickens, James E
2008-12-18 20:56 ` [PATCH 1/2] " James Pickens
2008-12-18 20:56 ` [PATCH 2/2] Add core.threadedcheckout config option James Pickens
2008-12-18 21:41 ` [PATCH 1/2] Add support for multi threaded checkout Linus Torvalds
2008-12-18 23:35 ` James Pickens
2008-12-19 0:13 ` Linus Torvalds
2008-12-18 21:02 ` [RFC PATCH 0/2] " Nicolas Pitre
2008-12-18 21:13 ` James Pickens
2008-12-18 21:16 ` Nicolas Morey-Chaisemartin
2008-12-18 21:42 ` James Pickens
2008-12-19 1:04 ` James Pickens [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=885649360812181704l3a905ebfrb90f391e86004efc@mail.gmail.com \
--to=jepicken@gmail.com \
--cc=devel@morey-chaisemartin.com \
--cc=git@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).