legend on top-right pane in 'git gui'

legend on top-right pane in 'git gui'

[Sitaram Chamarty]

Hello,

'git gui' has a minor issue with the legend on the main code
panel (yellow bar, top right pane).

When you click on a file in the top left pane, the yellow
bar becomes "untracked, not staged".  When you click on a
file in the bottom left pane, it becomes "staged for
commit".  So far so good.

But when you take a file and (un)stage a part of it, then
the text on the yellow bar changes to "Portions staged for
commit", regardless of whether you clicked on the filename
in the top left (unstaged) or bottom left (staged) pane.

One of the two texts should be different, but what?  I was
thinking, just add "(partial)" to the normal text, like:

    "untracked, not staged (partial)"
    "staged for commit (partial)"

I also tried to see if I could patch it, but it's not just a
matter of changing the text somewhere, and I don't know tcl.
However, if someone can give me a pointer I could still
try...

Any thoughts?

Re: legend on top-right pane in 'git gui'

[Sitaram Chamarty]

Hi guys,

Can someone at least tell me "Sita, you're wrong/this is a
stupid question/this is perfectly correct behaviour/whatever"?  :-)

I won't even ask why, I promise :-)

Regards,

Sitaram

On 2009-03-31, Sitaram Chamarty <sitaramc@gmail.com> wrote:
> Hello,
>
> 'git gui' has a minor issue with the legend on the main code
> panel (yellow bar, top right pane).
>
> When you click on a file in the top left pane, the yellow
> bar becomes "untracked, not staged".  When you click on a
> file in the bottom left pane, it becomes "staged for
> commit".  So far so good.
>
> But when you take a file and (un)stage a part of it, then
> the text on the yellow bar changes to "Portions staged for
> commit", regardless of whether you clicked on the filename
> in the top left (unstaged) or bottom left (staged) pane.
>
> One of the two texts should be different, but what?  I was
> thinking, just add "(partial)" to the normal text, like:
>
>     "untracked, not staged (partial)"
>     "staged for commit (partial)"
>
> I also tried to see if I could patch it, but it's not just a
> matter of changing the text somewhere, and I don't know tcl.
> However, if someone can give me a pointer I could still
> try...
>
> Any thoughts?
>

Re: legend on top-right pane in 'git gui'

[James Pickens]

On Wed, Apr 8, 2009, Sitaram Chamarty <sitaramc@gmail.com> wrote:
> Can someone at least tell me "Sita, you're wrong/this is a
> stupid question/this is perfectly correct behaviour/whatever"?  :-)
>
> I won't even ask why, I promise :-)

Well, I for one think your proposed new message - "untracked, not
staged (partial)" - is nonsense.  A file can't be both untracked
and partially staged.

Also I don't agree that the message needs to be different
depending on where you click; actually I think such behavior
would be more confusing to users than the current behavior.

James

Re: legend on top-right pane in 'git gui'

[Sitaram Chamarty]

On 2009-04-09, James Pickens <jepicken@gmail.com> wrote:
> On Wed, Apr 8, 2009, Sitaram Chamarty <sitaramc@gmail.com> wrote:
>> Can someone at least tell me "Sita, you're wrong/this is a
>> stupid question/this is perfectly correct behaviour/whatever"?  :-)
>>
>> I won't even ask why, I promise :-)
>
> Well, I for one think your proposed new message - "untracked, not
> staged (partial)" - is nonsense.  A file can't be both untracked
> and partially staged.

Fine, some other wording may suit better; doesn't matter if
you don't even agree that the message needs to be different.

> Also I don't agree that the message needs to be different
> depending on where you click; actually I think such behavior
> would be more confusing to users than the current behavior.

Right now, both panes say "Portions staged for commit".

In fact, while one pane does indeed show the portions staged
for commit, the other one is actually showing portions *not*
staged for commit.  To some of my users, that is certainly
confusing.

I guess confusion, like beauty, is in the eyes of the
beholder...