git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: James Pickens <jepicken@gmail.com>
To: "James P. Howard, II" <jh@jameshoward.us>
Cc: git@vger.kernel.org
Subject: Re: [PATCH] Add commit.status, --status, and --no-status
Date: Mon, 7 Dec 2009 17:39:51 -0700	[thread overview]
Message-ID: <885649360912071639o4c609dbapea9891aae639194c@mail.gmail.com> (raw)
In-Reply-To: <1260225927-33612-1-git-send-email-jh@jameshoward.us>

On Mon, Dec 7, 2009, James P. Howard, II <jh@jameshoward.us> wrote:
> This commit provides support for commit.status, --status, and
> --no-status, which control whether or not the git status information
> is included in the commit message template when using an editor to
> prepare the commit message.  It does not affect the effects of a
> user's commit.template settings.

At the risk of sounding like a curmudgeon, I have to register an objection
to this _as a config option_, for the same reasons that I objected to the
'grep --full-tree' config option [1].  Both options fundamentally change
user visible behavior, both options IMHO will be used by a small minority
of git users, and in both cases, the desired behavior can be attained using
aliases in combination with a new command line option.

Sorry if I'm obstructing progress, but I think that, for the good of the
Git community as a whole, it's best to keep the number of config options
(and to a lesser extent, command line options) as low as possible.

Note that I do not object to adding --no-status as a command line option.

[1] http://article.gmane.org/gmane.comp.version-control.git/133681

James

  reply	other threads:[~2009-12-08  0:40 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-12-04 23:04 [PATCH] Add commit.infodisplay option to give message editor empty file James P. Howard, II
2009-12-05  7:30 ` Junio C Hamano
2009-12-05 15:47   ` James P. Howard, II
2009-12-05 16:28     ` Jeff King
2009-12-05 23:09       ` James P. Howard, II
2009-12-06  4:22         ` Jeff King
2009-12-06  8:01           ` Junio C Hamano
2009-12-06 13:12             ` Jeff King
2009-12-07 22:45               ` [PATCH] Add commit.status, --status, and --no-status James P. Howard, II
2009-12-08  0:39                 ` James Pickens [this message]
2009-12-08  6:04                 ` Jeff King
2009-12-08  7:13                   ` Junio C Hamano
2009-12-08  7:55                     ` Jeff King
2009-12-08 14:07                     ` James P. Howard, II
2009-12-07 22:43           ` [PATCH] Add commit.infodisplay option to give message editor empty file James P. Howard, II

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=885649360912071639o4c609dbapea9891aae639194c@mail.gmail.com \
    --to=jepicken@gmail.com \
    --cc=git@vger.kernel.org \
    --cc=jh@jameshoward.us \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).