git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: "James P. Howard, II" <jh@jameshoward.us>
To: Junio C Hamano <gitster@pobox.com>
Cc: Jeff King <peff@peff.net>, git@vger.kernel.org
Subject: Re: [PATCH] Add commit.status, --status, and --no-status
Date: Tue, 8 Dec 2009 09:07:33 -0500	[thread overview]
Message-ID: <88a2333a0912080607q1881ce68j269eeba75769b1fa@mail.gmail.com> (raw)
In-Reply-To: <7vr5r6ndkz.fsf@alter.siamese.dyndns.org>

On Tue, Dec 8, 2009 at 02:13, Junio C Hamano <gitster@pobox.com> wrote:
> Jeff King <peff@peff.net> writes:
>
>> On Mon, Dec 07, 2009 at 05:45:27PM -0500, James P. Howard, II wrote:
>>
>>> This commit provides support for commit.status, --status, and
>>> --no-status, which control whether or not the git status information
>>> is included in the commit message template when using an editor to
>>> prepare the commit message.  It does not affect the effects of a
>>> user's commit.template settings.
>>
>> Thanks, this looks very cleanly done. The only complaint I would make is
>> that it should probably include a simple test case.
>
> Yes.  Also I am a _bit_ worried about the name "status", as the longer
> term direction is to make "status" not "a preview of commit", may confuse
> people who do read Release Notes.

Right now, this option does not affect how the commit message is prepared
in git tag.  If the option were extended to cover that case as well, what would
a sensible name for the option be, then?

James

-- 
James P. Howard, II, MPA MBCS
jh@jameshoward.us

  parent reply	other threads:[~2009-12-08 14:07 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-12-04 23:04 [PATCH] Add commit.infodisplay option to give message editor empty file James P. Howard, II
2009-12-05  7:30 ` Junio C Hamano
2009-12-05 15:47   ` James P. Howard, II
2009-12-05 16:28     ` Jeff King
2009-12-05 23:09       ` James P. Howard, II
2009-12-06  4:22         ` Jeff King
2009-12-06  8:01           ` Junio C Hamano
2009-12-06 13:12             ` Jeff King
2009-12-07 22:45               ` [PATCH] Add commit.status, --status, and --no-status James P. Howard, II
2009-12-08  0:39                 ` James Pickens
2009-12-08  6:04                 ` Jeff King
2009-12-08  7:13                   ` Junio C Hamano
2009-12-08  7:55                     ` Jeff King
2009-12-08 14:07                     ` James P. Howard, II [this message]
2009-12-07 22:43           ` [PATCH] Add commit.infodisplay option to give message editor empty file James P. Howard, II

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=88a2333a0912080607q1881ce68j269eeba75769b1fa@mail.gmail.com \
    --to=jh@jameshoward.us \
    --cc=git@vger.kernel.org \
    --cc=gitster@pobox.com \
    --cc=peff@peff.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).