From: Marc Herbert <Marc.Herbert@intel.com>
To: Junio C Hamano <gitster@pobox.com>, Andy Lowry <andy.work@nglowry.com>
Cc: Jeff King <peff@peff.net>, git <git@vger.kernel.org>,
Christian Kujau <lists@nerdbynature.de>,
josh@joshtriplett.org, michael.w.mason@intel.com,
linux-kernel@vger.kernel.org, linux-kbuild@vger.kernel.org
Subject: Wrong -dirty suffix set by setlocalversion (was: BUG in git diff-index)
Date: Wed, 27 Sep 2017 14:06:24 -0700 [thread overview]
Message-ID: <89d82c84-7a3b-9c4c-679e-a7a723669592@intel.com> (raw)
In-Reply-To: <d9b4725b-3204-03af-1bc2-6469bb815c63@intel.com>
+ linux-kbuild list which is not in the output of:
./scripts/get_maintainer.pl -f scripts/setlocalversion
... but seems relevant anyway.
On 31/03/16 13:39, Junio C Hamano wrote:
> Andy Lowry <andy.work@nglowry.com> writes:
>
>> So I think now that the script should do "update-index --refresh"
>> followed by "diff-index --quiet HEAD". Sound correct?
>
> Yes. That has always been one of the kosher ways for any script to
> make sure that the files in the working tree that are tracked have
> not been modified relative to HEAD (assuming that the index matches
> HEAD).
Too bad kernel/scripts/setlocalversion didn't get the memo:
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=cdf2bc632ebc9ef51
> scripts/setlocalversion on write-protected source tree (2013)
> I don't see how removing "git update-index" could do any harm.
This causes a spurious "-dirty" suffix when building from a directory copy
(as Mike learned the hard way)
[...]
https://public-inbox.org/git/1459432667.2124.2.camel@dwim.me
next prev parent reply other threads:[~2017-09-27 21:06 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-31 12:39 BUG in git diff-index Andy Lowry
2016-03-31 13:57 ` Carlos Martín Nieto
2016-03-31 14:05 ` Jeff King
2016-03-31 14:12 ` Andy Lowry
2016-03-31 14:27 ` Jeff King
2016-03-31 19:30 ` Andy Lowry
2016-03-31 20:39 ` Junio C Hamano
2017-09-26 19:46 ` Marc Herbert
2017-09-26 20:11 ` Eric Wong
2017-09-26 23:27 ` Google indexing https://public-inbox.org/git (was: BUG in git diff-index) Marc Herbert
2017-09-27 21:06 ` Marc Herbert [this message]
2018-05-24 23:03 ` Wrong -dirty suffix set by setlocalversion " Mike Mason
2018-05-25 3:50 ` Marc Herbert
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=89d82c84-7a3b-9c4c-679e-a7a723669592@intel.com \
--to=marc.herbert@intel.com \
--cc=andy.work@nglowry.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=josh@joshtriplett.org \
--cc=linux-kbuild@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lists@nerdbynature.de \
--cc=michael.w.mason@intel.com \
--cc=peff@peff.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).