git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: "Santi Béjar" <sbejar@gmail.com>
To: hanwen@xs4all.nl
Cc: git@vger.kernel.org
Subject: Re: Suggestion: drop 'g' in git-describe suffix
Date: Thu, 2 Nov 2006 12:12:32 +0100	[thread overview]
Message-ID: <8aa486160611020312v42047716t6a13e6fa16eeae8@mail.gmail.com> (raw)
In-Reply-To: <4549CE2A.3010808@xs4all.nl>

On 11/2/06, Han-Wen Nienhuys <hanwen@xs4all.nl> wrote:
> Andy Whitcroft escreveu:
> > Han-Wen Nienhuys wrote:
> >>
> >>   tag+sha1
> >>
> >> to separate the tag and the committish.
> >
> > Well there is a non-alphabet character in there, a minus (-).  The g
> > prefix on the sha1 _fragment_ it to indicate that it is in fact a
> > truncated sha1, not a complete one.

I think it is there to indicate it is a git commit sha1.

>
> is this policy documented somewhere?  None of the tools understand it.
>
> [lilydev@haring git]$ git describe
> v1.4.3.3-g1e1f76e
> [lilydev@haring git]$ git show g1e1f76e
> fatal: ambiguous argument 'g1e1f76e': unknown revision or path not in
> the working tree.
> Use '--' to separate paths from revisions
>

Use the complete output of describe:
$ git show v1.4.3.3-g1e1f76e

or the abbrev sha1:
$ git show 1e1f76e

> My suggestion is to use
>
>    v1.4.3.3+1e1f76e

My suggestion is to use:

v1.4.3.3-git1e1f76e

to make clear that it is a git revision version.

One problem I see with this scheme (either 'g', 'git' of '+') is that
it does not provide an increasing version number, even for
fast-forwarding commits. Then it is not useful as a package version
number (deb or rpm). I've already seen deb packages with
version+git20061010. One possibility could be to add the number of
commits between the tag and the commit as:

v1.4.3.3-git12g1e1f76e

to provide a weak ordering for fast-forwarding commits. What do you thing?


  parent reply	other threads:[~2006-11-02 11:12 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-11-02  1:23 Suggestion: drop 'g' in git-describe suffix Han-Wen Nienhuys
2006-11-02  1:47 ` Andy Whitcroft
2006-11-02  9:55   ` Han-Wen Nienhuys
2006-11-02 10:37     ` Andy Whitcroft
2006-11-02 10:53       ` Han-Wen Nienhuys
2006-11-02 10:59         ` Johannes Schindelin
2006-11-02 11:12         ` Santi Béjar [this message]
2006-11-02 11:21           ` Andy Whitcroft
2006-11-02 12:39             ` Santi Béjar
2006-11-02 13:52               ` Andy Whitcroft
2006-11-02 11:23           ` Han-Wen Nienhuys
2006-11-02 12:44             ` Santi Béjar
2006-11-02 14:07             ` Jakub Narebski
2006-11-02 14:48           ` Nicolas Vilz 'niv'
2006-11-02 15:01             ` Johannes Schindelin
2006-11-02 19:12               ` Nicolas Vilz 'niv'
2006-11-02 11:12         ` Andy Whitcroft
2006-11-02 11:03       ` Petr Baudis
2006-11-02 13:45         ` Carl Worth

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=8aa486160611020312v42047716t6a13e6fa16eeae8@mail.gmail.com \
    --to=sbejar@gmail.com \
    --cc=git@vger.kernel.org \
    --cc=hanwen@xs4all.nl \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).