git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: "Santi Béjar" <sbejar@gmail.com>
To: "Theodore Tso" <tytso@mit.edu>
Cc: "Junio C Hamano" <junkio@cox.net>,
	"Shawn O. Pearce" <spearce@spearce.org>,
	"James Bowes" <jbowes@dangerouslyinc.com>,
	git@vger.kernel.org, Johannes.Schindelin@gmx.de
Subject: Re: [PATCH] Make gc a builtin.
Date: Wed, 14 Mar 2007 08:55:05 +0100	[thread overview]
Message-ID: <8aa486160703140055s2b03c2aeu1c85dedac59b664b@mail.gmail.com> (raw)
In-Reply-To: <20070314074440.GC12710@thunk.org>

On 3/14/07, Theodore Tso <tytso@mit.edu> wrote:
> On Wed, Mar 14, 2007 at 12:19:07AM -0700, Junio C Hamano wrote:
> > >> -test "true" != "$pack_refs" ||
> > >> -git-pack-refs --prune &&
> > >> -git-reflog expire --all &&
> > >> -git-repack -a -d -l &&
> > >> ...
> >
> > I do not necessarily think so.  This is not even a performance
> > critical part of the system, so if there _were_ no other
> > constraints, I would rather keep scripts like this as scripts.
>
> I agree with Junio; I think the scripts are much more readable and
> easier to understand; In fact, it would be nice if the script were
> preserved somewhere, perhaps as comments in the .c file.
>

Or move them to contrib/examples, as was done with git-resolve.sh.

Santi

  reply	other threads:[~2007-03-14  7:55 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-03-14  1:58 [PATCH] Make gc a builtin James Bowes
2007-03-14  6:07 ` Shawn O. Pearce
2007-03-14  7:19   ` Junio C Hamano
2007-03-14  7:44     ` Theodore Tso
2007-03-14  7:55       ` Santi Béjar [this message]
2007-03-14  9:29         ` Junio C Hamano
2007-03-14 10:45       ` Andy Parkins
2007-03-14 11:12         ` Junio C Hamano
2007-03-14 11:48           ` Andy Parkins
2007-03-14 12:19           ` Johannes Schindelin
  -- strict thread matches above, loose matches on Subject: below --
2007-03-13 23:03 James Bowes
2007-03-14  1:05 ` Johannes Schindelin
2007-03-14  1:37   ` Brian Gernhardt
2007-03-11 22:06 [PATCH 0/2] " James Bowes
2007-03-11 22:06 ` [PATCH 2/2] " James Bowes
2007-03-11 22:48   ` Johannes Schindelin
2007-03-12  2:11     ` Junio C Hamano
2007-03-12  2:51       ` [PATCH] " James Bowes
2007-03-12 14:43         ` Shawn O. Pearce

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=8aa486160703140055s2b03c2aeu1c85dedac59b664b@mail.gmail.com \
    --to=sbejar@gmail.com \
    --cc=Johannes.Schindelin@gmx.de \
    --cc=git@vger.kernel.org \
    --cc=jbowes@dangerouslyinc.com \
    --cc=junkio@cox.net \
    --cc=spearce@spearce.org \
    --cc=tytso@mit.edu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).