git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: "Santi Béjar" <sbejar@gmail.com>
To: "Johannes Schindelin" <Johannes.Schindelin@gmx.de>
Cc: "Jakub Narebski" <jnareb@gmail.com>, git@vger.kernel.org
Subject: Re: Wishlist for a bundle-only transport mode
Date: Thu, 22 Nov 2007 10:42:42 +0100	[thread overview]
Message-ID: <8aa486160711220142w25e9c9b6vbafa34a287dde7eb@mail.gmail.com> (raw)
In-Reply-To: <Pine.LNX.4.64.0711211719330.27959@racer.site>

On Nov 21, 2007 6:26 PM, Johannes Schindelin <Johannes.Schindelin@gmx.de> wrote:
> Hi,
>
> On Wed, 21 Nov 2007, Jakub Narebski wrote:
>
> > Johannes Schindelin wrote:
> > > On Wed, 21 Nov 2007, Jakub Narebski wrote:
> > >
> > >> That has the disadvantage of pushing to bundle when you make an error
> > >> in the lastpart of path to existing repository.
> > >
> > > As I wrote in another reply, I would not allow overwriting an existing
> > > file.
> >
> > > Specifying a non-existing file should be good enough.
> >
> > What I meant here that if you do "git push /some/path/to/rpeo.git", with
> > mistake in the last part of path to repository, you would end up with a
> > bundle, and you would have to really watch what happened to catch the
> > error.
>
> I use tab completion all the time, so this would not happen to me.  IMHO
> that is a lesser issue than to introduce a "protocol".
>
> > I'd rather use "git push bundle:///some/path/to/bundle" or "git push
> > --bundle bundlename" to catch errors better.

I would vote for the later, and a way to configure this in the config.

> >
> > Besides it should be IMHO be possible to overwrite bundle if you are
> > doing fast-forward push...
>
> Not as far as I can see.  A push there would see what the bundle has
> already, and put them into the new bundle as _prerequisites_.  So the
> bundle would lose information.

I prefer not to overwrite an existing bundle.

>
> BTW this was my gripe (that I decided not to make public earlier) with
> Santi's proposal to begin with: a push would not have any way to specify
> what the other side has already.  So I think "git push <bundle>" is the
> wrong way of creating a bundle.

Sorry but I do not understand this. I think this two lines could be equivalent:

git push --bundle bundle.bdl "refs/heads/master:refs/remotes/bundle/master"
git bundle create bundle.bdl refs/heads/master ^refs/remotes/bundle/master

>
> Except if we add some cunning strategy not to overwrite, ever, but to
> create <bundle>.<n> with an incrementing <n>.  But that might be too much.

That make sense.

Santi

  parent reply	other threads:[~2007-11-22  9:43 UTC|newest]

Thread overview: 33+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-11-21 14:54 Wishlist for a bundle-only transport mode Santi Béjar
2007-11-21 15:04 ` Jakub Narebski
2007-11-21 15:24   ` Santi Béjar
2007-11-21 15:46   ` Johannes Schindelin
2007-11-21 16:52     ` Jakub Narebski
2007-11-21 16:59       ` Johannes Schindelin
2007-11-21 17:11         ` Jakub Narebski
2007-11-21 17:26           ` Johannes Schindelin
2007-11-21 17:52             ` Jakub Narebski
2007-11-22  9:42             ` Santi Béjar [this message]
2007-11-22 10:02               ` Junio C Hamano
2007-11-23  9:18                 ` Jakub Narebski
2007-11-23  9:31                   ` Junio C Hamano
2007-11-23 10:04                     ` Jakub Narebski
2007-11-23 10:13                     ` Santi Béjar
2007-11-23 12:18                       ` Johannes Schindelin
2007-11-23 15:06                       ` Junio C Hamano
2007-11-23 15:34                         ` Santi Béjar
2007-11-23 16:05                           ` Junio C Hamano
2007-11-23 16:39                             ` Santi Béjar
2007-11-24 19:15                               ` Junio C Hamano
2007-11-23 19:09                           ` Jakub Narebski
2007-11-21 15:59 ` Johannes Schindelin
2007-11-21 16:15   ` Santi Béjar
2007-11-21 16:36     ` Johannes Schindelin
2007-11-21 16:44       ` Santi Béjar
2007-11-21 16:53     ` [PATCH] bundle create: keep symbolic refs' names instead of resolving them Johannes Schindelin
2007-11-22 12:03       ` Johannes Schindelin
2007-11-22 12:24       ` [REPLACEMENT PATCH] " Johannes Schindelin
2007-11-21 16:23   ` Wishlist for a bundle-only transport mode Kristian Høgsberg
2007-11-21 17:07     ` Johannes Schindelin
2007-11-21 17:06 ` Jakub Narebski
2007-11-21 17:29   ` Johannes Schindelin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=8aa486160711220142w25e9c9b6vbafa34a287dde7eb@mail.gmail.com \
    --to=sbejar@gmail.com \
    --cc=Johannes.Schindelin@gmx.de \
    --cc=git@vger.kernel.org \
    --cc=jnareb@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).