git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: "Santi Béjar" <sbejar@gmail.com>
To: "Jeff King" <peff@peff.net>
Cc: git@vger.kernel.org, "Alex Riesen" <raa.lkml@gmail.com>
Subject: Re: [PATCH 3/3] commit: Show the committer ident when is different from the parent
Date: Thu, 1 May 2008 10:34:44 +0200	[thread overview]
Message-ID: <8aa486160805010134l4746f9afhec546a9d49fd7a6d@mail.gmail.com> (raw)
In-Reply-To: <20080430192639.GC30344@sigill.intra.peff.net>

On Wed, Apr 30, 2008 at 9:26 PM, Jeff King <peff@peff.net> wrote:
> On Wed, Apr 30, 2008 at 09:23:43PM +0200, Santi Béjar wrote:
>
>  > >  I like the idea in general, but the implementation could be refined.
>  > >  Maybe consider looking at user.name (whether the repo has an ident
>  > >  set)? This is usually done conciously, and the user wont need this
>  > >  reminder.
>  >
>  > Maybe only show the committer ident when both happens:
>  >
>  > 1) the committer ident is different from the parent
>  > 2) the committer ident is set automatically
>
>  Honestly, I think just "2)" is probably fine (where automatically
>  presumably means "from GECOS"). I see what you are trying to accomplish
>  with "1)", but it's so workflow specific as to be useless.

I don't see "1) as workflow specific, it is there to minimize the
number of time it is shown, ie somebody might prefer the automatic
ident, so as long as it does not change it is not shown.

Santi

  reply	other threads:[~2008-05-01  8:35 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-04-30  8:47 [PATCH 0/3] Show author and/or committer in some cases Santi Béjar
2008-04-30  8:47 ` [PATCH 1/3] Preparation to call determine_author_info from prepare_to_commit Santi Béjar
2008-04-30  8:47 ` [PATCH 2/3] commit: Show author if different from committer Santi Béjar
2008-04-30  8:47 ` [PATCH 3/3] commit: Show the committer ident when is different from the parent Santi Béjar
2008-04-30 14:50   ` Jeff King
2008-04-30 15:10     ` Jeff King
2008-04-30 16:37     ` Jeff King
2008-04-30 19:23       ` Santi Béjar
2008-04-30 19:26         ` Jeff King
2008-05-01  8:34           ` Santi Béjar [this message]
2008-05-01 13:51             ` Jeff King
2008-05-01 19:02               ` Junio C Hamano
2008-05-01 22:28                 ` Jeff King
2008-05-02  9:25                   ` Santi Béjar
2008-04-30 17:52   ` Alex Riesen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=8aa486160805010134l4746f9afhec546a9d49fd7a6d@mail.gmail.com \
    --to=sbejar@gmail.com \
    --cc=git@vger.kernel.org \
    --cc=peff@peff.net \
    --cc=raa.lkml@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).