From: "Santi Béjar" <sbejar@gmail.com>
To: "Junio C Hamano" <junio@pobox.com>
Cc: git@vger.kernel.org
Subject: Re: [PATCHv4 4/4] user.warnautomatic: add config to control if the committer ident is shown
Date: Wed, 7 May 2008 18:32:24 +0200 [thread overview]
Message-ID: <8aa486160805070932w44edf4b0j3b712ec22c10fe7d@mail.gmail.com> (raw)
In-Reply-To: <7v8wymdred.fsf@gitster.siamese.dyndns.org>
On Wed, May 7, 2008 at 6:12 PM, Junio C Hamano <junio@pobox.com> wrote:
> Santi Béjar <sbejar@gmail.com> writes:
>
> > Signed-off-by: Santi Béjar <sbejar@gmail.com>
>
> By setting this new variable the user can squelch undesired noise the
> previous change introduces, but the user can just set user.name and
> user.email to desired values to squelch it anyway.
Or the user prefers the automatic ident.
>
> So either this new variable is superfluous, or the previous change is too
> susceptible to produce false positives that need squelching with such a
> variable, or both. In any case, not a very good sign.
For me it is superfluous, as I prefer to see what is the committer
ident when it is generated.
I even said I prefer just showing the automatic ident. I sent it in
case it was decided it was worth.
Santi
next prev parent reply other threads:[~2008-05-07 16:33 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-05-04 16:04 [PATCHv4 0/4] Show author and/or committer in some cases Santi Béjar
2008-05-04 16:04 ` [PATCHv4 1/4] Preparation to call determine_author_info from prepare_to_commit Santi Béjar
2008-05-04 16:12 ` Santi Béjar
2008-05-04 16:04 ` [PATCHv4 2/4] commit: Show author if different from committer Santi Béjar
2008-05-06 23:34 ` Junio C Hamano
2008-05-04 16:04 ` [PATCHv4 3/4] commit: Show committer if automatic Santi Béjar
2008-05-04 16:04 ` [PATCHv4 4/4] user.warnautomatic: add config to control if the committer ident is shown Santi Béjar
2008-05-07 16:12 ` Junio C Hamano
2008-05-07 16:32 ` Santi Béjar [this message]
2008-05-04 16:25 ` [PATCHv4 0/4] Show author and/or committer in some cases Santi Béjar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8aa486160805070932w44edf4b0j3b712ec22c10fe7d@mail.gmail.com \
--to=sbejar@gmail.com \
--cc=git@vger.kernel.org \
--cc=junio@pobox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).