From: "Santi Béjar" <sbejar@gmail.com>
To: "Junio C Hamano" <gitster@pobox.com>
Cc: "Marcel Koeppen" <git-dev@marzelpan.de>, git@vger.kernel.org
Subject: Re: [PATCH] Fix sed syntax in t7502-commit for OSX
Date: Thu, 15 May 2008 11:37:32 +0200 [thread overview]
Message-ID: <8aa486160805150237t734b24dcw4a153e41cbc7436e@mail.gmail.com> (raw)
In-Reply-To: <7vwslwgdyi.fsf@gitster.siamese.dyndns.org>
On Thu, May 15, 2008 at 10:37 AM, Junio C Hamano <gitster@pobox.com> wrote:
>
> But more importantly, as we are serious about portability, we should not
> be using "sed -i" which is not even in POSIX to begin with.
Is there a way (environment variable, flag) to test if it is POSIX? Or
we just have to know?
I'll send a patch to document the "sed -i" issue in
Documentation/CodingGuidelines.
> Can we
> rewrite these places without using the in-place extension?
Yes, I'll do it soon if nobody beats me.
Santi
next prev parent reply other threads:[~2008-05-15 9:38 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-05-15 2:19 [PATCH] Fix sed syntax in t7502-commit for OSX Marcel Koeppen
2008-05-15 8:37 ` Junio C Hamano
2008-05-15 8:58 ` Holger Schurig
2008-05-15 11:06 ` Marcel Koeppen
2008-05-15 9:37 ` Santi Béjar [this message]
2008-05-16 0:21 ` [PATCH] Replace in-place sed in t7502-commit Marcel Koeppen
2008-05-16 9:56 ` Jeff King
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8aa486160805150237t734b24dcw4a153e41cbc7436e@mail.gmail.com \
--to=sbejar@gmail.com \
--cc=git-dev@marzelpan.de \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).