From: "James North" <tocapicha@gmail.com>
To: git <git@vger.kernel.org>
Subject: Re: Encoding problems using git-svn
Date: Thu, 30 Oct 2008 04:28:23 +0100 [thread overview]
Message-ID: <8b168cfb0810292028x225202b9hece862a350440472@mail.gmail.com> (raw)
In-Reply-To: <8b168cfb0810282014r789ac01dnec51824de1078f0@mail.gmail.com>
Ok, I made a quick change in git-svn script and seems like is working
now in my system with locale set to iso-8859-1.
Dunno if this is the right place to post this, but I hope someone
knowledgeable see this and tells if this would work as a general fix.
This patch is against 1.6.0.2
--- git-svn 2008-09-15 13:04:46.000000000 +0200
+++ git-svn.mine 2008-10-30 04:21:09.000000000 +0100
@@ -43,6 +43,7 @@
use Getopt::Long qw/:config gnu_getopt no_ignore_case auto_abbrev/;
use IPC::Open3;
use Git;
+use Encode;
BEGIN {
# import functions from Git into our packages, en masse
@@ -1061,6 +1062,7 @@
&& !$saw_from) {
$msgbuf .= "\n\nFrom: $author";
}
+ $msgbuf = encode("utf8", $msgbuf);
print $log_fh $msgbuf or croak $!;
command_close_pipe($msg_fh, $ctx);
}
On Wed, Oct 29, 2008 at 4:14 AM, James North <tocapicha@gmail.com> wrote:
> Hi,
>
> I'm using git-svn on a system with ISO-8859-1 encoding. The problem is
> when I try to use "git svn dcommit" to send changes to a remote svn
> (also ISO-8859-1).
>
> Seems like git-svn is sending commit messages with utf-8 (just a
> guessing...) and they look bad on the remote svn log. E.g. "Ca?\241a
> de cami?\243n"
>
> I have tried using i18n.commitencoding=ISO-8859-1 as suggested by the
> warning when doing "git svn dcommit" but messages still are sent with
> wrong encoding.
>
> I'm mising something?
>
> Thanks everyone
>
next prev parent reply other threads:[~2008-10-30 3:37 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-10-29 3:14 Encoding problems using git-svn James North
2008-10-30 3:28 ` James North [this message]
2008-10-30 7:41 ` Eric Wong
2008-10-30 15:14 ` James North
2008-11-02 9:48 ` Eric Wong
2008-11-02 13:45 ` Robin Rosenberg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8b168cfb0810292028x225202b9hece862a350440472@mail.gmail.com \
--to=tocapicha@gmail.com \
--cc=git@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).