From: Celeste Liu <coelacanthushex@gmail.com>
To: Junio C Hamano <gitster@pobox.com>, Patrick Steinhardt <ps@pks.im>
Cc: git@vger.kernel.org
Subject: Re: [PATCH] doc: replace 3 dash with correct 2 dash in git-config(1)
Date: Mon, 26 Aug 2024 23:56:44 +0800 [thread overview]
Message-ID: <8c1c031b-4f36-4825-93ef-408c50b0ee2f@gmail.com> (raw)
In-Reply-To: <xmqqa5gznwf9.fsf@gitster.g>
On 2024-08-26 23:19, Junio C Hamano wrote:
> Patrick Steinhardt <ps@pks.im> writes:
>
>>>> There's one more thing I noticed: the synopsis for `git config get` says
>>>> `--regrexp=<regexp>`, which is clearly wrong. As you're already at it,
>>>> would you mind including a second patch that corrects this?
>>>
>>> I couldn't find this typo. Did I miss something? If something missed, please
>>> tell me. I will include it in v3.
>>> v2 has been sent.
>>
>> It's in line 13 in Documentation/git-config.txt. Seeing that your v2 is
>
> Ahhhh. You weren't saying "regexp is misspelt as regrexp". You're
> right. I too missed it.
Ohhhhh. I missed it.
A comment which include typo and point out a typo led my brain to wrong way.
And is there need a new patch to fix this? Or you will fix it directly?
>
> The synopsis should lose "=<regexp>" part, as the option does not
> take any arguments.
>
> Thanks.
next prev parent reply other threads:[~2024-08-26 15:56 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-08-22 17:20 [PATCH] doc: replace 3 dash with correct 2 dash in git-config(1) Celeste Liu
2024-08-22 18:02 ` Junio C Hamano
2024-08-23 5:45 ` Patrick Steinhardt
2024-08-23 7:59 ` Celeste Liu
2024-08-23 8:21 ` Celeste Liu
2024-08-26 6:24 ` Patrick Steinhardt
2024-08-26 15:19 ` Junio C Hamano
2024-08-26 15:56 ` Celeste Liu [this message]
2024-08-26 17:19 ` Junio C Hamano
2024-08-26 17:31 ` [PATCH] git-config.1: --get-all description update Junio C Hamano
2024-08-26 17:32 ` [PATCH] doc: replace 3 dash with correct 2 dash in git-config(1) Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8c1c031b-4f36-4825-93ef-408c50b0ee2f@gmail.com \
--to=coelacanthushex@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=ps@pks.im \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).