git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: "Lars Hjemli" <lh@elementstorage.no>
To: "Shawn Pearce" <spearce@spearce.org>
Cc: "Jakub Narebski" <jnareb@gmail.com>, git@vger.kernel.org
Subject: Re: [RFC] Teach git-branch howto rename a branch
Date: Sat, 25 Nov 2006 10:16:19 +0100	[thread overview]
Message-ID: <8c5c35580611250116h466e3649p2630ee6641b6e6f4@mail.gmail.com> (raw)
In-Reply-To: <20061125085731.GG4528@spearce.org>

On 11/25/06, Shawn Pearce <spearce@spearce.org> wrote:
> Jakub Narebski <jnareb@gmail.com> wrote:
> >
> > And of course reflog should store the fact of renaming branch.
>
> Yes, I think that's a worthwhile thing to log.  Problem is the
> logging system tends to throw away pointless entries (sha1 ->
> same sha1) so the rename log entry needs to be forced somehow...

Is it ok to put

static int log_ref_write(struct ref_lock *lock,
	const unsigned char *sha1, const char *msg)

into refs.h?

Then it should be possibly to do something like this:

  lock = lock_ref_sha1(ref, sha1);
  lock->force_write = 1;
  log_ref_write(lock, sha1, "Renamed oldname to newname");
  unlock_ref(lock);

...after moving the reflog...

-- 

  reply	other threads:[~2006-11-25  9:16 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-11-24 23:03 [RFC] Teach git-branch howto rename a branch Lars Hjemli
2006-11-25  5:40 ` Junio C Hamano
2006-11-25  6:49   ` Shawn Pearce
2006-11-25  8:53     ` Jakub Narebski
2006-11-25  8:57       ` Shawn Pearce
2006-11-25  9:16         ` Lars Hjemli [this message]
2006-11-25 10:35           ` Junio C Hamano
2006-11-25 10:52             ` Lars Hjemli
2006-11-25  7:12   ` [PATCH] git-branch -D: make it work even when on a yet-to-be-born branch Junio C Hamano
2006-11-25  8:52   ` [RFC] Teach git-branch howto rename a branch Lars Hjemli
2006-11-25 10:39 ` Fredrik Kuivinen
2006-11-25 11:00   ` Lars Hjemli
2006-11-26 23:56 ` Josef Weidendorfer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=8c5c35580611250116h466e3649p2630ee6641b6e6f4@mail.gmail.com \
    --to=lh@elementstorage.no \
    --cc=git@vger.kernel.org \
    --cc=jnareb@gmail.com \
    --cc=spearce@spearce.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).