From: "Lars Hjemli" <hjemli@gmail.com>
To: "Linus Torvalds" <torvalds@osdl.org>
Cc: git@vger.kernel.org
Subject: Re: [ANNOUNCE] CGit v0.1-pre
Date: Mon, 11 Dec 2006 09:33:36 +0100 [thread overview]
Message-ID: <8c5c35580612110033y4f6260c9xffeaf4457f4ead21@mail.gmail.com> (raw)
In-Reply-To: <Pine.LNX.4.64.0612101653420.12500@woody.osdl.org>
On 12/11/06, Linus Torvalds <torvalds@osdl.org> wrote:
> you really want to re-check the existence after you got the lock,
> otherwise you would race with somebody else that got the lock, generated
> the data, and then unlocked (and you got the lock _after_ the data was
> generated, so now you generate it unnecessarily).
Yes, you're right. Thanks for noticing.
But this also applies to the case where the cachefile has expired,
right? In that case, after getting the lock, I have to recheck that
the cachefile is _still_ expired.
Anyway, I must say I find it rather unlikely for these cases to occur
(frequently) in real life. That would seem to imply that the caching
isn't really needed at all.
>
> As a side note: how do you release your caches?
>
Simple timeouts (time()-stat.st_mtime), depending on what kind of page
was requested. If anyone cares about invalid cache content (branch
head moving), relevant cachefiles can be deleted with an update-hook.
--
next prev parent reply other threads:[~2006-12-11 8:33 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-12-10 23:42 [ANNOUNCE] CGit v0.1-pre Lars Hjemli
2006-12-11 0:08 ` Jakub Narebski
[not found] ` <8c5c35580612101616g179715ecyd02fcbb023246ecc@mail.gmail.com>
2006-12-11 0:29 ` Jakub Narebski
2006-12-11 13:37 ` Michael
2006-12-11 1:04 ` Linus Torvalds
2006-12-11 8:33 ` Lars Hjemli [this message]
2006-12-11 11:59 ` Lars Hjemli
2006-12-11 17:01 ` Linus Torvalds
2006-12-11 17:33 ` Linus Torvalds
2006-12-11 17:40 ` Lars Hjemli
2006-12-11 18:18 ` Linus Torvalds
2006-12-11 18:38 ` Lars Hjemli
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8c5c35580612110033y4f6260c9xffeaf4457f4ead21@mail.gmail.com \
--to=hjemli@gmail.com \
--cc=git@vger.kernel.org \
--cc=torvalds@osdl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).