git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: "Lars Hjemli" <hjemli@gmail.com>
To: "Jakub Narebski" <jnareb@gmail.com>
Cc: git@vger.kernel.org, "Michael Niedermayer" <michaelni@gmx.at>,
	"Aaron Gray" <angray@beeb.net>
Subject: Re: suggestions for gitweb
Date: Sun, 13 May 2007 18:52:16 +0200	[thread overview]
Message-ID: <8c5c35580705130952r7c0e353dr9cf20aed61bdd463@mail.gmail.com> (raw)
In-Reply-To: <f25mic$1b1$2@sea.gmane.org>

On 5/13/07, Jakub Narebski <jnareb@gmail.com> wrote:
> Aaron Gray wrote:
>
> >>> * the history/log pages could contain some statistics for the commits
> >>>   like the number of files changed and lines added/removed
> >>
> >> Probably.
> >>
> >> The three last items should be relatively easy, if somebody is
> >> interested.  Pasky, Jakub, what do you think?
> >
> > I would like to see lines of code and file sizes too.
>
> Diff statistics for difftree / whatchanged, or diff shortstat is a bit
> costly, as it needs to generate and examine diff, and not only compare
> trees. Besides --numstat doesn't support renames well now, but that
> might not be an obstacle.
>
> Lines of code and file sizes: file size needs additional invocation
> per each file for gitweb; it would be easier for cgit. Costly! Counting
> LOC is even more costly

I've implemented number of files/lines changed in cgit's log view and
pushed it to http://hjemli.net/git/

It does consume some cpu (especially on the linux-2.6 repo), but it's
not terribly bad (and the caching helps out). But I felt like changing
the number of commits per page to 50, so I added a knob for this in
the config file while at it.

I'll try to get a proper diffstat on the commit page + file history
via tree view next (filesize has always been part of cgits tree view
btw).

--
larsh

  parent reply	other threads:[~2007-05-13 16:52 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-05-12 20:55 suggestions for gitweb Michael Niedermayer
2007-05-12 22:39 ` Junio C Hamano
2007-05-12 23:15   ` Aaron Gray
2007-05-13  0:41     ` Jakub Narebski
2007-05-13  0:54       ` Junio C Hamano
2007-05-13 11:50         ` Jakub Narebski
2007-05-13 16:52       ` Lars Hjemli [this message]
2007-05-14  7:31         ` Suggestions for cgit (was: Re: suggestions for gitweb) Jakub Narebski
2007-05-14  8:50           ` Lars Hjemli
2007-05-15 12:57             ` Lars Hjemli
2007-05-13  0:01   ` suggestions for gitweb Michael Niedermayer
2007-05-13 11:18     ` Jakub Narebski
2007-05-14  0:28       ` Junio C Hamano
2007-05-14  1:08     ` Petr Baudis
2007-05-14  2:00       ` Michael Niedermayer
2007-05-14  2:36         ` Petr Baudis
2007-05-14  8:53           ` Michael Niedermayer
2007-05-14  9:58             ` Petr Baudis
2007-05-14 16:49               ` Jakub Narebski
2007-05-14 17:37                 ` Michael Niedermayer
2007-05-15 15:46         ` Jan Hudec

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=8c5c35580705130952r7c0e353dr9cf20aed61bdd463@mail.gmail.com \
    --to=hjemli@gmail.com \
    --cc=angray@beeb.net \
    --cc=git@vger.kernel.org \
    --cc=jnareb@gmail.com \
    --cc=michaelni@gmx.at \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).