git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: "Lars Hjemli" <hjemli@gmail.com>
To: "Johannes Schindelin" <Johannes.Schindelin@gmx.de>
Cc: "Junio C Hamano" <junkio@cox.net>, git@vger.kernel.org
Subject: Re: [PATCH] Add git-submodule command
Date: Sat, 26 May 2007 00:33:25 +0200	[thread overview]
Message-ID: <8c5c35580705251533r21a3dea5w5d263fad9f8bbfa7@mail.gmail.com> (raw)
In-Reply-To: <Pine.LNX.4.64.0705251924280.4648@racer.site>

On 5/25/07, Johannes Schindelin <Johannes.Schindelin@gmx.de> wrote:
> [* many usefull comments about the docs *]

Thanks, will fix

> > +USAGE='[--init | --update | --cached] [--quiet] [--] [<path>...]'
> > +. git-sh-setup
> > +require_work_tree
>
> Maybe
>
>         test -f "$GIT_DIR"/.gitmodules || die "Not a superproject"
>
> Hmm?

Yeah, maybe. But the command will only touch entries with mode 160000
anyway, so it might not be a big deal.

>
> > +                     rmdir "$path" 2>/dev/null ||
>
> Just out of curiousity: is rmdir portable? I always used "rm -r"...

I have no idea, really. But the reason for using rmdir was this
section of the man page:

NAME
       rmdir - remove empty directories

I do not want to delete an unempty directory. But there is probably
some better way to do this?

--
larsh

      parent reply	other threads:[~2007-05-25 22:33 UTC|newest]

Thread overview: 26+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-05-25  9:51 [PATCH] Add git-submodule command Lars Hjemli
2007-05-25 10:57 ` Johannes Schindelin
2007-05-25 12:24 ` Johannes Schindelin
2007-05-25 13:46   ` Lars Hjemli
2007-05-25 13:58     ` Johannes Schindelin
2007-05-25 14:16       ` Lars Hjemli
2007-05-25 14:47         ` Johannes Schindelin
2007-05-25 14:52           ` Lars Hjemli
2007-05-25 18:09             ` Lars Hjemli
2007-05-25 18:41               ` Johannes Schindelin
2007-05-25 19:31                 ` Junio C Hamano
2007-05-25 20:29                   ` Lars Hjemli
2007-05-25 20:52                     ` Junio C Hamano
2007-05-25 22:01                       ` Lars Hjemli
2007-05-26  0:17                         ` Lars Hjemli
2007-05-26  0:48                           ` Johannes Schindelin
2007-05-26  1:23                           ` Junio C Hamano
2007-05-26  9:39                             ` Lars Hjemli
2007-05-26 10:42                             ` Johannes Schindelin
2007-05-26 13:56                             ` Lars Hjemli
2007-05-26 14:37                               ` Simon Hausmann
2007-05-26 14:48                                 ` Lars Hjemli
2007-05-25 20:30                   ` Johannes Schindelin
2007-05-25 19:57                 ` Linus Torvalds
2007-05-25 20:28                   ` Johannes Schindelin
2007-05-25 22:33                 ` Lars Hjemli [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=8c5c35580705251533r21a3dea5w5d263fad9f8bbfa7@mail.gmail.com \
    --to=hjemli@gmail.com \
    --cc=Johannes.Schindelin@gmx.de \
    --cc=git@vger.kernel.org \
    --cc=junkio@cox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).