git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: "Lars Hjemli" <hjemli@gmail.com>
To: skimo@liacs.nl
Cc: "Junio C Hamano" <junkio@cox.net>, git@vger.kernel.org
Subject: Re: [PATCH] Let .git/config specify the url for submodules
Date: Fri, 1 Jun 2007 17:56:34 +0200	[thread overview]
Message-ID: <8c5c35580706010856s390b1157p3ea0d28cb2074cae@mail.gmail.com> (raw)
In-Reply-To: <20070601145104.GY955MdfPADPa@greensroom.kotnet.org>

On 6/1/07, Sven Verdoolaege <skimo@kotnet.org> wrote:
> On Fri, Jun 01, 2007 at 04:45:06PM +0200, Lars Hjemli wrote:
> > On 6/1/07, Sven Verdoolaege <skimo@kotnet.org> wrote:
> > >On Fri, Jun 01, 2007 at 11:25:42AM +0200, Lars Hjemli wrote:
> > >> [path '$path']
> > >>  submodule=modulename
> > >>  url=/some/url
> > >
> > >Wouldn't it make more sense to have
> > >
> > >[path '$path']
> > >        submodule=modulename
> > >
> > >and
> > >
> > >[submodule '$modulename']
> > >        url=/some/url
> > >
> > >in case the same module appears in more than one path?
> >
> > Yes, that would be a properly normalized model.
> >
> > Hmm.... Maybe we could allow both variations, with your suggestion
> > overriding mine if both are present? (I think there would be many
> > cases where the extra level of [submodule...] wouldn't be needed.
>
> Hmm.... I was thinking that the extra "path" level could be optional,
> i.e., if there is no path.$path.submodule, then the name of the
> submodule would simply be $path.

Yeah, that should also work out. Time for a quick poll?

-- 
larsh

  reply	other threads:[~2007-06-01 15:56 UTC|newest]

Thread overview: 37+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-05-28 20:51 [PATCH] Let .git/config specify the url for submodules Lars Hjemli
2007-05-31  0:17 ` Lars Hjemli
2007-05-31 23:43   ` Junio C Hamano
2007-06-01  8:08   ` Josef Weidendorfer
2007-06-01  9:17     ` Lars Hjemli
2007-06-01  8:57   ` Sven Verdoolaege
2007-06-01  9:25     ` Lars Hjemli
2007-06-01  9:35       ` Sven Verdoolaege
2007-06-01 14:45         ` Lars Hjemli
2007-06-01 14:51           ` Sven Verdoolaege
2007-06-01 15:56             ` Lars Hjemli [this message]
2007-06-01 16:29               ` Linus Torvalds
2007-06-01 19:55                 ` Junio C Hamano
2007-06-02  7:13                   ` Lars Hjemli
2007-06-02  7:44                     ` Sven Verdoolaege
2007-06-02  8:39                       ` Lars Hjemli
2007-06-02  9:15                         ` Junio C Hamano
2007-06-02  9:53                           ` Lars Hjemli
2007-06-02 10:12                             ` Junio C Hamano
2007-06-02 10:38                               ` Lars Hjemli
2007-07-20 17:23                       ` [PATCH] git-submodule fixes for call to git config --get-regexp Chris Larson
2007-07-20 18:07                         ` Junio C Hamano
2007-07-20 18:36                           ` Johannes Schindelin
2007-07-25  0:09                             ` submodule init problem Ricky Nite
2007-07-25  0:30                               ` Ricky Nite
2007-07-25  1:49                                 ` Junio C Hamano
2007-07-25  8:15                                   ` Sven Verdoolaege
2007-07-25 20:25                                     ` Lars Hjemli
2007-07-25 20:31                                       ` Johannes Schindelin
2007-07-25 20:40                                         ` Lars Hjemli
2007-07-25 20:50                                           ` Johannes Schindelin
2007-07-25 22:20                                     ` Junio C Hamano
2007-07-25 23:43                                       ` Ricky Nite
2007-07-25 23:49                                         ` Junio C Hamano
2007-06-02  7:49                 ` [PATCH] Let .git/config specify the url for submodules Sven Verdoolaege
2007-06-02 16:34                   ` Linus Torvalds
2007-06-02 17:35                     ` Sven Verdoolaege

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=8c5c35580706010856s390b1157p3ea0d28cb2074cae@mail.gmail.com \
    --to=hjemli@gmail.com \
    --cc=git@vger.kernel.org \
    --cc=junkio@cox.net \
    --cc=skimo@liacs.nl \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).