From: "Lars Hjemli" <hjemli@gmail.com>
To: "Junio C Hamano" <junkio@cox.net>
Cc: "Linus Torvalds" <torvalds@linux-foundation.org>,
skimo@liacs.nl, git@vger.kernel.org
Subject: Re: [PATCH] Let .git/config specify the url for submodules
Date: Sat, 2 Jun 2007 09:13:55 +0200 [thread overview]
Message-ID: <8c5c35580706020013g2a4039fcsdf8974da8cd4c2c2@mail.gmail.com> (raw)
In-Reply-To: <7vfy5bzby1.fsf@assigned-by-dhcp.cox.net>
On 6/1/07, Junio C Hamano <junkio@cox.net> wrote:
> Linus Torvalds <torvalds@linux-foundation.org> writes:
>
> > On Fri, 1 Jun 2007, Lars Hjemli wrote:
> > ...
> > Ack. I think the natural thing for a lot of cases is the trivial "module
> > name == path" case, so having to have
> >
> > [path "kernel"]
> > module = kernel
> >
> > for that case just sounds unnecessary.
> >
> > That said, I wonder if it wouldn't be more natural to do things the other
> > way around, because quite often a "module" (under CVS conventions) is a
> > *set* of directories, so with that in mind, it might be better to have the
> > mapping be something like this:
> >
> > [module "infrastructure"]
> > submodule = lib
> > submodule = build
> >
> > [submodule "lib"]
> > url = git://xyzzy/lib-1.2.3
> >
> > [submodule "build"]
> > url = git://xyzzy/build-0.61
> >
> > and make the rule be:
> > - submodules are named by their paths (ie "path == submodule")
> > - a module is a set of such submodules/paths
> > - if no "module" is defined, the default is to just use the
> > path/submodule name
>
> I take that if you do want to name a submodule differently from
> its (currently in-tree) path, you would do something like...
>
> [submodule "xyzzylib"]
> path = lib
> url = git://xyzzy/lib-1.2.3
>
The reason I wanted to use
[path "lib"]
submodule=xyzzylib
url=git://xyzzy/lib-1.2.3
is that the git-submodule command always starts out with the submodule
path, trying to map that to an url or a submodule name. My proposal
allows
$ name=$(GIT_CONFIG=.gitmodules git-config path."$path".submodule)
$ url=$(GIT_CONFIG=.gitmodules git-config path."$path".url)
Then Sven suggested to create a submodule section for the url, which would allow
$ name=$(GIT_CONFIG=.gitmodules git-config path."$path".submodule)
$ url=$(GIT_CONFIG=.gitmodules git-config submodule."$name".url)
But I don't see an easy way to do the mapping from path to url/submodule with:
[submodule "xyzzylib"]
path=lib
url=git://xyzzy/lib-1.2.3
Suggestions?
--
larsh
next prev parent reply other threads:[~2007-06-02 7:14 UTC|newest]
Thread overview: 37+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-05-28 20:51 [PATCH] Let .git/config specify the url for submodules Lars Hjemli
2007-05-31 0:17 ` Lars Hjemli
2007-05-31 23:43 ` Junio C Hamano
2007-06-01 8:08 ` Josef Weidendorfer
2007-06-01 9:17 ` Lars Hjemli
2007-06-01 8:57 ` Sven Verdoolaege
2007-06-01 9:25 ` Lars Hjemli
2007-06-01 9:35 ` Sven Verdoolaege
2007-06-01 14:45 ` Lars Hjemli
2007-06-01 14:51 ` Sven Verdoolaege
2007-06-01 15:56 ` Lars Hjemli
2007-06-01 16:29 ` Linus Torvalds
2007-06-01 19:55 ` Junio C Hamano
2007-06-02 7:13 ` Lars Hjemli [this message]
2007-06-02 7:44 ` Sven Verdoolaege
2007-06-02 8:39 ` Lars Hjemli
2007-06-02 9:15 ` Junio C Hamano
2007-06-02 9:53 ` Lars Hjemli
2007-06-02 10:12 ` Junio C Hamano
2007-06-02 10:38 ` Lars Hjemli
2007-07-20 17:23 ` [PATCH] git-submodule fixes for call to git config --get-regexp Chris Larson
2007-07-20 18:07 ` Junio C Hamano
2007-07-20 18:36 ` Johannes Schindelin
2007-07-25 0:09 ` submodule init problem Ricky Nite
2007-07-25 0:30 ` Ricky Nite
2007-07-25 1:49 ` Junio C Hamano
2007-07-25 8:15 ` Sven Verdoolaege
2007-07-25 20:25 ` Lars Hjemli
2007-07-25 20:31 ` Johannes Schindelin
2007-07-25 20:40 ` Lars Hjemli
2007-07-25 20:50 ` Johannes Schindelin
2007-07-25 22:20 ` Junio C Hamano
2007-07-25 23:43 ` Ricky Nite
2007-07-25 23:49 ` Junio C Hamano
2007-06-02 7:49 ` [PATCH] Let .git/config specify the url for submodules Sven Verdoolaege
2007-06-02 16:34 ` Linus Torvalds
2007-06-02 17:35 ` Sven Verdoolaege
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8c5c35580706020013g2a4039fcsdf8974da8cd4c2c2@mail.gmail.com \
--to=hjemli@gmail.com \
--cc=git@vger.kernel.org \
--cc=junkio@cox.net \
--cc=skimo@liacs.nl \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).