From: "Lars Hjemli" <hjemli@gmail.com>
To: "Junio C Hamano" <gitster@pobox.com>
Cc: "Johannes Schindelin" <Johannes.Schindelin@gmx.de>,
"Sven Verdoolaege" <skimo@kotnet.org>,
git@vger.kernel.org
Subject: Re: [PATCH 1/3] git-submodule: allow submodule name and path to differ
Date: Sun, 10 Jun 2007 10:37:58 +0200 [thread overview]
Message-ID: <8c5c35580706100137m3c3f3d24n873f2474a8835e0e@mail.gmail.com> (raw)
In-Reply-To: <7vbqfod57b.fsf@assigned-by-dhcp.cox.net>
On 6/10/07, Junio C Hamano <gitster@pobox.com> wrote:
> Lars Hjemli <hjemli@gmail.com> writes:
>
> > This teaches git-submodule to check module.*.path when looking for the
> > config for a submodule path. If no match is found it falls back to the
> > current behaviour (module.$path).
>
> I have a feeling that it might be much less troublesome in the
> longer term to admit that module.$path was a mistake and support
> only one format;
Hmm, what the patch does should match what is described in
http://article.gmane.org/gmane.comp.version-control.git/48879
except that I've kept [module] instead of renaming it to [submodule].
But my wording ("module.$path") might be disconcerting :)
Fwiw: I do admit that the [path "path"] construct was a mistake.
--
larsh
next prev parent reply other threads:[~2007-06-10 8:38 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-06-09 21:38 [PATCH 0/3] submodule improvements Lars Hjemli
2007-06-09 21:38 ` [PATCH 1/3] git-submodule: allow submodule name and path to differ Lars Hjemli
2007-06-10 0:27 ` Junio C Hamano
2007-06-10 7:25 ` Johannes Schindelin
2007-06-10 8:23 ` Junio C Hamano
2007-06-10 8:42 ` Lars Hjemli
2007-06-10 8:37 ` Lars Hjemli [this message]
2007-06-09 21:38 ` [PATCH 2/3] Add gitmodules(5) Lars Hjemli
2007-06-10 0:28 ` Frank Lichtenheld
2007-06-10 8:58 ` Lars Hjemli
2007-06-10 9:48 ` Johannes Schindelin
2007-06-10 10:10 ` Lars Hjemli
2007-06-10 12:12 ` Sven Verdoolaege
2007-06-10 12:30 ` Lars Hjemli
2007-06-10 12:40 ` Sven Verdoolaege
2007-06-10 12:51 ` Lars Hjemli
2007-06-10 20:57 ` Junio C Hamano
2007-06-10 21:14 ` Lars Hjemli
2007-06-11 8:34 ` Sven Verdoolaege
2007-06-11 10:47 ` Lars Hjemli
2007-06-11 11:04 ` Sven Verdoolaege
2007-06-11 16:17 ` Junio C Hamano
2007-06-13 15:36 ` Matthias Lederhofer
2007-06-13 16:13 ` Lars Hjemli
2007-06-13 16:31 ` Matthias Lederhofer
2007-06-13 16:59 ` Lars Hjemli
2007-06-13 16:20 ` Junio C Hamano
2007-06-13 22:01 ` [PATCH] gitmodules(5): remove leading period from synopsis Lars Hjemli
2007-06-09 21:38 ` [PATCH 3/3] t7400: barf if git-submodule removes or replaces a file Lars Hjemli
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8c5c35580706100137m3c3f3d24n873f2474a8835e0e@mail.gmail.com \
--to=hjemli@gmail.com \
--cc=Johannes.Schindelin@gmx.de \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=skimo@kotnet.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).