Re: [ANNOUNCE] cgit v0.7

["Lars Hjemli" <hjemli@gmail.com>]

On Nov 5, 2007 1:29 AM, Jakub Narebski <jnareb@gmail.com> wrote:
> Lars Hjemli wrote:
> > cgit v0.7 (a fast webinterface for git) is now available
>
>  * Very nice cgit logo,

Thanks!

> but no favicon. Perhaps pacman head and G,
>    or pacman head (like in logo) and +/-...

I've never cared much about favicons, but I guess cgit could provide one.

>
>  * Providing reference with full sha1 of referenced object for tags
>    list is not IMVHO a good design: what is interesting is type of
>    tag, if it is signed it's first line, and if it is lightweight
>    pointing to tag then perhaps commit subject.

Yes, the full sha1 is not very interesting. But I'm not sure what to
replace it with: the first line of annotated tags is very often
identical to tag name. Maybe it should just abbreviate the sha1?

>
>  * Nice diffstat in commit view; the diff view is better, although I
>    wouldn't lump from-file / to-file diff header together with git
>    diff header and extended git diff header.

I've tried to make the diff look similar to 'git log -p' output, but I
agree the first line per file is probably overkill.

>
>  * I like the sidebar very much, although I'm not sure how it would
>    work for larger projects (more branches, much more tags).

How do you think it works out with http://hjemli.net/git/xorg/xserver/
? It's got an impressive number of branches and tags ;-)

> Also the
>    search textbox is not very visible; I'd rather it have "groove"
>    view.

Agreed, it's probably useless trying to style input-controls: the
result is heavily browser/platform dependent.


>  * I like separate 'mirrors' section, although I think it rather
>    clashes badly with notion of forks (alternates).

Well, it's only a section header, i.e. a parameter in cgitrc


>  * I'm not sure if it wouln't be beter to provide -n/+m lines changed
>    instead of nn likes changed column.

Maybe. I think it used to be -n/+m, but then I changed it; don't
remember why...

>
>  * Nice submodule support!

Heh, it's a simple hack, but thanks anyway. It probably needs to be
configurable per repo though.

>
> By the way, Freedesktop provides besides standard gitweb interface
> also cgit interface at
>   http://cgit.freedesktop.org/
> Take a look at how such site looks like with large number of projects
> (perhaps sidebar is noot such a good idea then?), and with large
> projects.

Actually, the filtered branch/tag lists was done partly because of
freedesktop.org. I think it has worked out nicely (but
cgit.freedesktop.org needs to run the latest cgit). Also, the width of
project descriptions is configurable, so it can take up much less
space and leave room for the sidebar.

Thanks for the comments, you've made my day!

-- 
larsh