From: "Lars Hjemli" <hjemli@gmail.com>
To: "Junio C Hamano" <gitster@pobox.com>
Cc: imyousuf@gmail.com, git@vger.kernel.org,
"Imran M Yousuf" <imyousuf@smartitengineering.com>
Subject: Re: [PATCH] - Added recurse command to git submodule
Date: Wed, 9 Jan 2008 11:42:40 +0100 [thread overview]
Message-ID: <8c5c35580801090242g3f755814pa56e896d0a8723bb@mail.gmail.com> (raw)
In-Reply-To: <7vmyrfjsw1.fsf@gitster.siamese.dyndns.org>
On Jan 9, 2008 9:38 AM, Junio C Hamano <gitster@pobox.com> wrote:
> I am not still convinced that a subcommand other than init,
> which is started recursively, should initialize and update
> submodules that are uninitialized.
I very much agree; this behaviour would break the current 'usage model'.
> I suspect that it might be a saner approach to:
>
> - allow "git submodule recurse init [-d depth]" (although I am
> not sure if limit by depth is so useful in practice -- only
> experience will tell us) to auto-initialize the uninitialized
> submodules;
A possible extension is to specifiy "inter-submodule" paths to the
init subcommand, i.e. for a possible KDE layout:
git submodule -r init kdelibs kdelibs/admin
This should then recursively initialize the kdelibs submodule and the
admin-submodule (in the kdelibs submodule).
Btw: from my reading of the code, the git-command specified for
'recurse' will be done top-to-bottom: I guess that's what you want for
something like 'git submodule recurse diff', but not for something
like 'git submodule recurse commit' (but IMHO the latter one should
never be executed ;-)
--
larsh
next prev parent reply other threads:[~2008-01-09 10:43 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-01-09 5:51 [PATCH] - Added recurse command to git submodule imyousuf
2008-01-09 8:38 ` Junio C Hamano
2008-01-09 8:55 ` Imran M Yousuf
2008-01-09 10:42 ` Lars Hjemli [this message]
2008-01-09 20:26 ` Junio C Hamano
2008-01-10 3:27 ` Imran M Yousuf
2008-01-10 4:09 ` Junio C Hamano
2008-01-10 4:50 ` Imran M Yousuf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8c5c35580801090242g3f755814pa56e896d0a8723bb@mail.gmail.com \
--to=hjemli@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=imyousuf@gmail.com \
--cc=imyousuf@smartitengineering.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).