From: Lars Hjemli <hjemli@gmail.com>
To: Junio C Hamano <gitster@pobox.com>
Cc: "René Scharfe" <rene.scharfe@lsrfire.ath.cx>, git@vger.kernel.org
Subject: Re: [PATCH 2/3] Teach read_tree_recursive() how to traverse into submodules
Date: Sun, 18 Jan 2009 20:50:06 +0100 [thread overview]
Message-ID: <8c5c35580901181150t1827455elbe2be224a33f1b36@mail.gmail.com> (raw)
In-Reply-To: <7vfxjgxwv7.fsf@gitster.siamese.dyndns.org>
On Sun, Jan 18, 2009 at 20:00, Junio C Hamano <gitster@pobox.com> wrote:
> Lars Hjemli <hjemli@gmail.com> writes:
>
>> I like the idea, but it will require thorough review of all
>> read_tree_recursive() consumers. So now we've got three different
>> approaches:
>> * me: global setting
>> * dscho: parameter to read_tree_recursive()
>> * you: accept the return value from the callback function
>>
>> Junio, what would you prefer?
>
> As usual René has the best taste in designing things ;-)
Agreed. I've pushed an updated series using his approach to the
lh/traverse-gitlinks branch in git://hjemli.net/pub/git/git
(http://hjemli.net/git/git/log/?h=lh/traverse-gitlinks), but without a
fix for Dscho's concern about the behaviour in
tree.c::traverse_gitlink(). Hopefully I'll get to send a reworked
series later tonight.
--
larsh
next prev parent reply other threads:[~2009-01-18 19:51 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-01-18 10:53 [PATCH 0/3] Implement 'git archive --submodules' Lars Hjemli
2009-01-18 10:53 ` [PATCH 1/3] sha1_file: add function to insert alternate object db Lars Hjemli
2009-01-18 10:53 ` [PATCH 2/3] Teach read_tree_recursive() how to traverse into submodules Lars Hjemli
2009-01-18 10:53 ` [PATCH 3/3] git-archive: add support for --submodules Lars Hjemli
2009-01-18 15:51 ` Johannes Schindelin
2009-01-18 15:48 ` [PATCH 2/3] Teach read_tree_recursive() how to traverse into submodules Johannes Schindelin
2009-01-18 17:45 ` Lars Hjemli
2009-01-18 18:33 ` Johannes Schindelin
2009-01-18 19:45 ` Lars Hjemli
2009-01-18 21:02 ` Johannes Schindelin
2009-01-18 21:31 ` Lars Hjemli
2009-01-18 21:55 ` Johannes Schindelin
2009-01-18 22:46 ` Lars Hjemli
2009-01-19 1:24 ` Johannes Schindelin
2009-01-19 2:01 ` [PATCH/RFC v1 1/1] bug fix, diff whitespace ignore options Keith Cascio
2009-01-19 3:53 ` Johannes Schindelin
2009-01-19 18:03 ` [PATCH/RFC v2 " Keith Cascio
2009-01-19 18:36 ` Johannes Schindelin
2009-01-20 7:04 ` Junio C Hamano
2009-01-19 3:02 ` [PATCH 2/3] Teach read_tree_recursive() how to traverse into submodules Junio C Hamano
2009-01-18 16:13 ` René Scharfe
2009-01-18 16:37 ` Lars Hjemli
2009-01-18 19:00 ` Junio C Hamano
2009-01-18 19:50 ` Lars Hjemli [this message]
2009-01-18 15:32 ` [PATCH 1/3] sha1_file: add function to insert alternate object db Johannes Schindelin
2009-01-18 15:55 ` [PATCH] " Lars Hjemli
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8c5c35580901181150t1827455elbe2be224a33f1b36@mail.gmail.com \
--to=hjemli@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=rene.scharfe@lsrfire.ath.cx \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).